From 658601ed934f11952cc90c34b2cfce29fabde81f Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 24 Apr 2018 08:37:51 +0000 Subject: [PATCH] Revert "Do not build 'all' on iOS trybots." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 5f2c0cc0adfafa2e99fea900cd60103f8d2018c4. Reason for revert: "all" is now green. Original change's description: > Do not build 'all' on iOS trybots. > > It seems iOS trybots are the only ones that build "all". This causes > problems when using Abseil because some targets in > //third_party/abseil-cpp fail to build (because they depend on CCTZ). > > Bug: webrtc:8821 > Change-Id: I017ecb0527a7e3f3c59f41053fa1878d16cbe4e9 > No-Try: True > Reviewed-on: https://webrtc-review.googlesource.com/70140 > Commit-Queue: Mirko Bonadei > Reviewed-by: Patrik Höglund > Cr-Commit-Position: refs/heads/master@{#22890} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821 Change-Id: I49014d4cc74bb84ec85f05e0e678cecf14bf5db0 Reviewed-on: https://webrtc-review.googlesource.com/72002 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#22994} --- tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios_dbg.json | 2 +- tools_webrtc/ios/tryserver.webrtc/ios_rel.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json b/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json index f840977258..a82cfead56 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json @@ -12,7 +12,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Debug", "sdk": "iphonesimulator9.3", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json b/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json index c3f2e18f41..28f96201fc 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json @@ -12,7 +12,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Debug", "sdk": "iphonesimulator10.3", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json b/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json index 6738f24f0f..4a2ad07d8e 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json @@ -12,7 +12,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Debug", "sdk": "iphonesimulator11.0", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json b/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json index 5380912832..4c1af2d3bd 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json @@ -12,7 +12,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Debug", "sdk": "iphonesimulator9.3", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json b/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json index bfa083fbe7..a718b7acad 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json @@ -13,7 +13,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Debug", "sdk": "iphoneos10.3", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json b/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json index 576f54c9d7..7d2f923b57 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json @@ -14,7 +14,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Release", "sdk": "iphoneos10.3", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json b/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json index 51a4415332..4c5aca5ef7 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json @@ -13,7 +13,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Debug", "sdk": "iphoneos10.3", "tests": [ diff --git a/tools_webrtc/ios/tryserver.webrtc/ios_rel.json b/tools_webrtc/ios/tryserver.webrtc/ios_rel.json index 4803b3fef0..81c16db60a 100644 --- a/tools_webrtc/ios/tryserver.webrtc/ios_rel.json +++ b/tools_webrtc/ios/tryserver.webrtc/ios_rel.json @@ -14,7 +14,7 @@ "use_goma=true" ], "use_analyze": false, - "additional_compile_targets": [], + "additional_compile_targets": [ "all" ], "configuration": "Release", "sdk": "iphoneos10.3", "tests": [