admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix use-after-move in VideoReceiveStream2

Browse Source 
Fix multiple use-after-move issues in VideoReceiveStream2, as found by
clang-tidy:

  video/video_receive_stream2.cc:259:
  'config' used after it was moved
  video/video_receive_stream2.cc:199:
  move occurred here

Bug: chromium:1122844
Change-Id: I6367dc835f002718a5353c3e0b64c2a154e79925
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241201
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35530}
This commit is contained in:
Maksim Ivanov 2021-12-14 02:43:32 +01:00 committed by WebRTC LUCI CQ
parent f947bb98c3
commit 63b97de330
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
video/video_receive_stream2.cc
View File

@ -222,8 +222,8 @@ VideoReceiveStream2::VideoReceiveStream2(
std::move(config_.frame_decryptor),
std::move(config_.frame_transformer)),
rtp_stream_sync_(call->worker_thread(), this),
max_wait_for_keyframe_ms_(DetermineMaxWaitForFrame(config, true)),
max_wait_for_frame_ms_(DetermineMaxWaitForFrame(config, false)),
max_wait_for_keyframe_ms_(DetermineMaxWaitForFrame(config_, true)),
max_wait_for_frame_ms_(DetermineMaxWaitForFrame(config_, false)),
low_latency_renderer_enabled_("enabled", true),
low_latency_renderer_include_predecode_buffer_("include_predecode_buffer",
true),
@ -256,10 +256,10 @@ VideoReceiveStream2::VideoReceiveStream2(
if (config_.rtp.rtx_ssrc) {
rtx_receive_stream_ = std::make_unique<RtxReceiveStream>(
&rtp_video_stream_receiver_, config.rtp.rtx_associated_payload_types,
&rtp_video_stream_receiver_, config_.rtp.rtx_associated_payload_types,
config_.rtp.remote_ssrc, rtp_receive_statistics_.get());
} else {
rtp_receive_statistics_->EnableRetransmitDetection(config.rtp.remote_ssrc,
rtp_receive_statistics_->EnableRetransmitDetection(config_.rtp.remote_ssrc,
true);
}