From 62d63a0ab3e532ea6b15ed3f86bb39bffc0a0dc4 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Thu, 13 Oct 2022 16:24:33 +0200 Subject: [PATCH] metrics: cleanup CandidatePoolUsage metrics which have shown that it is not easily possible to restrict the pool size to 1 and combine this with max-bundle BUG=webrtc:12383,chromium:1328218 Change-Id: I3a7ae4a263238c1b5faa079c3cbdaf84d1b40cbc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279141 Reviewed-by: Harald Alvestrand Reviewed-by: Johannes Kron Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/main@{#38396} --- pc/peer_connection.cc | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/pc/peer_connection.cc b/pc/peer_connection.cc index 4615ce5a2c..0c10d33d75 100644 --- a/pc/peer_connection.cc +++ b/pc/peer_connection.cc @@ -1948,29 +1948,6 @@ void PeerConnection::ReportFirstConnectUsageMetrics() { RTC_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.BundlePolicy", policy, kBundlePolicyUsageMax); - // Record configured ice candidate pool size depending on the - // BUNDLE policy. See - // https://w3c.github.io/webrtc-pc/#dom-rtcconfiguration-icecandidatepoolsize - // The ICE candidate pool size is an optimization and it may be desirable - // to restrict the maximum size of the pre-gathered candidates. - switch (configuration_.bundle_policy) { - case kBundlePolicyBalanced: - RTC_HISTOGRAM_COUNTS_LINEAR( - "WebRTC.PeerConnection.CandidatePoolUsage.Balanced", - configuration_.ice_candidate_pool_size, 0, 255, 256); - break; - case kBundlePolicyMaxBundle: - RTC_HISTOGRAM_COUNTS_LINEAR( - "WebRTC.PeerConnection.CandidatePoolUsage.MaxBundle", - configuration_.ice_candidate_pool_size, 0, 255, 256); - break; - case kBundlePolicyMaxCompat: - RTC_HISTOGRAM_COUNTS_LINEAR( - "WebRTC.PeerConnection.CandidatePoolUsage.MaxCompat", - configuration_.ice_candidate_pool_size, 0, 255, 256); - break; - } - // Record whether there was a local or remote provisional answer. ProvisionalAnswerUsage pranswer = kProvisionalAnswerNotUsed; if (local_description()->GetType() == SdpType::kPrAnswer) {