From 6144b8422bb3b99cdd0f292674d129fa49a816fa Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Fri, 4 Jun 2021 13:49:27 +0200 Subject: [PATCH] red: fix renegotiation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If RED is no longer used the send codec needs to be reconfigured. To test on https://webrtc.github.io/samples/src/content/peerconnection/audio/ run: await pc1.setLocalDescription(); await pc1.setRemoteDescription({type: 'answer', sdp: pc1.remoteDescription.sdp.replace('red/48000', 'blue/48000')}) As a result, RED will be turned off and the bitrate will drop. BUG=webrtc:11640 Change-Id: Icc7a83ae29e67d054399bf42010264e94c32127d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221360 Commit-Queue: Henrik Lundin Reviewed-by: Henrik Lundin Reviewed-by: Per Åhgren Cr-Commit-Position: refs/heads/master@{#34719} --- audio/audio_send_stream.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/audio/audio_send_stream.cc b/audio/audio_send_stream.cc index 62dd53d337..455bb84e04 100644 --- a/audio/audio_send_stream.cc +++ b/audio/audio_send_stream.cc @@ -701,7 +701,9 @@ bool AudioSendStream::ReconfigureSendCodec(const Config& new_config) { new_config.send_codec_spec->format != old_config.send_codec_spec->format || new_config.send_codec_spec->payload_type != - old_config.send_codec_spec->payload_type) { + old_config.send_codec_spec->payload_type || + new_config.send_codec_spec->red_payload_type != + old_config.send_codec_spec->red_payload_type) { return SetupSendCodec(new_config); }