admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused VideoReceiveStreamInterface::Config::target_delay_ms field.

Browse Source 
Bug: webrtc:14128
Change-Id: I83aa23124ed260b836930463aa712ddd097cef84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263142
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37031}
This commit is contained in:
Rasmus Brandt 2022-05-23 10:34:27 +02:00 committed by WebRTC LUCI CQ
parent e9c3f0158c
commit 60de8aab46
4 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
call/video_receive_stream.cc
View File

@ -110,7 +110,6 @@ std::string VideoReceiveStreamInterface::Config::ToString() const {
ss << ", render_delay_ms: " << render_delay_ms;
if (!sync_group.empty())
ss << ", sync_group: " << sync_group;
ss << ", target_delay_ms: " << target_delay_ms;
ss << '}';
return ss.str();

4
call/video_receive_stream.h
View File

@ -247,10 +247,6 @@ class VideoReceiveStreamInterface : public MediaReceiveStreamInterface {
// to one of the audio streams.
std::string sync_group;
// Target delay in milliseconds. A positive value indicates this stream is
// used for streaming instead of a real-time call.
int target_delay_ms = 0;
// An optional custom frame decryptor that allows the entire frame to be
// decrypted in whatever way the caller choses. This is not required by
// default.

2
test/call_config_utils.cc
View File

@ -37,7 +37,6 @@ VideoReceiveStreamInterface::Config ParseVideoReceiveStreamJsonConfig(
receive_config.decoders.push_back(decoder);
}
receive_config.render_delay_ms = json["render_delay_ms"].asInt64();
receive_config.target_delay_ms = json["target_delay_ms"].asInt64();
receive_config.rtp.remote_ssrc = json["rtp"]["remote_ssrc"].asInt64();
receive_config.rtp.local_ssrc = json["rtp"]["local_ssrc"].asInt64();
receive_config.rtp.rtcp_mode =
@ -118,7 +117,6 @@ Json::Value GenerateVideoReceiveStreamJsonConfig(
root_json["rtp"] = rtp_json;
root_json["render_delay_ms"] = config.render_delay_ms;
root_json["target_delay_ms"] = config.target_delay_ms;
return root_json;
}

2
test/call_config_utils_unittest.cc
View File

@ -25,7 +25,6 @@ TEST(CallConfigUtils, MarshalUnmarshalProcessSameObject) {
decoder.video_format.parameters["99"] = "b";
recv_config.decoders.push_back(decoder);
recv_config.render_delay_ms = 10;
recv_config.target_delay_ms = 15;
recv_config.rtp.remote_ssrc = 100;
recv_config.rtp.local_ssrc = 101;
recv_config.rtp.rtcp_mode = RtcpMode::kCompound;
@ -48,7 +47,6 @@ TEST(CallConfigUtils, MarshalUnmarshalProcessSameObject) {
EXPECT_EQ(recv_config.decoders[0].video_format.parameters,
unmarshaled_config.decoders[0].video_format.parameters);
EXPECT_EQ(recv_config.render_delay_ms, unmarshaled_config.render_delay_ms);
EXPECT_EQ(recv_config.target_delay_ms, unmarshaled_config.target_delay_ms);
EXPECT_EQ(recv_config.rtp.remote_ssrc, unmarshaled_config.rtp.remote_ssrc);
EXPECT_EQ(recv_config.rtp.local_ssrc, unmarshaled_config.rtp.local_ssrc);
EXPECT_EQ(recv_config.rtp.rtcp_mode, unmarshaled_config.rtp.rtcp_mode);