From 60c5668f1ee15d4fe1e82fb78ae58aa68f11a0f7 Mon Sep 17 00:00:00 2001 From: oprypin Date: Fri, 24 Mar 2017 03:22:49 -0700 Subject: [PATCH] Fix cpplint errors in locations that are already being checked Otherwise cpplint will trigger during presubmit for unrelated changes in these files. BUG=webrtc:5149 NOTRY=True Review-Url: https://codereview.webrtc.org/2767393003 Cr-Commit-Position: refs/heads/master@{#17371} --- webrtc/common_video/h264/profile_level_id.cc | 2 +- webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc | 1 + .../modules/rtp_rtcp/source/rtp_packet_history_unittest.cc | 1 + webrtc/modules/video_coding/jitter_estimator_tests.cc | 5 +++-- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/webrtc/common_video/h264/profile_level_id.cc b/webrtc/common_video/h264/profile_level_id.cc index f682862ca1..cd04bb5b3f 100644 --- a/webrtc/common_video/h264/profile_level_id.cc +++ b/webrtc/common_video/h264/profile_level_id.cc @@ -47,7 +47,7 @@ constexpr uint8_t ByteMaskString(char c, const char (&str)[9]) { // either 0 or 1. class BitPattern { public: - constexpr BitPattern(const char (&str)[9]) + explicit constexpr BitPattern(const char (&str)[9]) : mask_(~ByteMaskString('x', str)), masked_value_(ByteMaskString('1', str)) {} diff --git a/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc b/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc index c4edc732b8..19b98a69f3 100644 --- a/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc +++ b/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc @@ -12,6 +12,7 @@ #include #include +#include #include "webrtc/base/checks.h" #include "webrtc/base/logging.h" diff --git a/webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc index 2a7caf188f..52ef81a67c 100644 --- a/webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc +++ b/webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc @@ -11,6 +11,7 @@ #include "webrtc/modules/rtp_rtcp/source/rtp_packet_history.h" #include +#include #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "webrtc/modules/rtp_rtcp/source/rtp_packet_to_send.h" diff --git a/webrtc/modules/video_coding/jitter_estimator_tests.cc b/webrtc/modules/video_coding/jitter_estimator_tests.cc index e2fd9f758a..04480a7c2f 100644 --- a/webrtc/modules/video_coding/jitter_estimator_tests.cc +++ b/webrtc/modules/video_coding/jitter_estimator_tests.cc @@ -46,7 +46,8 @@ class TestVCMJitterEstimator : public ::testing::Test { // Generates some simple test data in the form of a sawtooth wave. class ValueGenerator { public: - ValueGenerator(int32_t amplitude) : amplitude_(amplitude), counter_(0) {} + explicit ValueGenerator(int32_t amplitude) + : amplitude_(amplitude), counter_(0) {} virtual ~ValueGenerator() {} int64_t Delay() { return ((counter_ % 11) - 5) * amplitude_; } @@ -157,4 +158,4 @@ TEST_F(TestVCMJitterEstimator, TestConvergence) { EXPECT_NE(low_rate_iterations, 0); EXPECT_LE(low_rate_iterations, regular_iterations); } -} +} // namespace webrtc