From 60aaa03ee14bd4a37cef4f75a9592ae1f88116e9 Mon Sep 17 00:00:00 2001 From: Bjorn Terelius Date: Mon, 10 Dec 2018 14:29:46 +0100 Subject: [PATCH] Fix header extension mapping bug in RTC event log analyzer. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The header extensions for a receive stream should also be used for the associated RTX stream, but not for the (RTCP) send stream. Bug: webrtc:10113 Change-Id: Ibeb25a4490d7f628f1b360bf4d6f7edf444ba22a Reviewed-on: https://webrtc-review.googlesource.com/c/113807 Reviewed-by: Erik Språng Commit-Queue: Björn Terelius Cr-Commit-Position: refs/heads/master@{#25955} --- logging/rtc_event_log/rtc_event_log_parser_new.cc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/logging/rtc_event_log/rtc_event_log_parser_new.cc b/logging/rtc_event_log/rtc_event_log_parser_new.cc index 7926f3bf9c..b0d9504d0c 100644 --- a/logging/rtc_event_log/rtc_event_log_parser_new.cc +++ b/logging/rtc_event_log/rtc_event_log_parser_new.cc @@ -1137,10 +1137,7 @@ void ParsedRtcEventLogNew::StoreParsedLegacyEvent(const rtclog::Event& event) { if (!config.rtp_extensions.empty()) { incoming_rtp_extensions_maps_[config.remote_ssrc] = RtpHeaderExtensionMap(config.rtp_extensions); - // TODO(terelius): I don't understand the reason for configuring header - // extensions for the local SSRC. I think it should be removed, but for - // now I want to preserve the previous functionality. - incoming_rtp_extensions_maps_[config.local_ssrc] = + incoming_rtp_extensions_maps_[config.rtx_ssrc] = RtpHeaderExtensionMap(config.rtp_extensions); } incoming_video_ssrcs_.insert(config.remote_ssrc); @@ -1170,8 +1167,6 @@ void ParsedRtcEventLogNew::StoreParsedLegacyEvent(const rtclog::Event& event) { if (!config.rtp_extensions.empty()) { incoming_rtp_extensions_maps_[config.remote_ssrc] = RtpHeaderExtensionMap(config.rtp_extensions); - incoming_rtp_extensions_maps_[config.local_ssrc] = - RtpHeaderExtensionMap(config.rtp_extensions); } incoming_audio_ssrcs_.insert(config.remote_ssrc); break;