From 608298b6aeca37c35b757fefaf34e41f3ba7df3c Mon Sep 17 00:00:00 2001
From: Danil Chapovalov <danilchap@webrtc.org>
Date: Thu, 18 Oct 2018 14:20:44 +0200
Subject: [PATCH] Move RtcEventLog::CreateNull implementation near declaration.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

having implementation and declaration in same build target helps
setting dependencies

Bug: None
Change-Id: Ibf22e9c8781def9d84ce4562d0f0eaba5abd39cf
Reviewed-on: https://webrtc-review.googlesource.com/c/106900
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25255}
---
 logging/BUILD.gn                            | 1 +
 logging/rtc_event_log/rtc_event_log.cc      | 6 ++++++
 logging/rtc_event_log/rtc_event_log_impl.cc | 4 ----
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/logging/BUILD.gn b/logging/BUILD.gn
index 6340b49e74..329690601e 100644
--- a/logging/BUILD.gn
+++ b/logging/BUILD.gn
@@ -42,6 +42,7 @@ rtc_source_set("rtc_event_log_api") {
     "../rtc_base:ptr_util",
     "../rtc_base:rtc_base_approved",
     "../rtc_base:rtc_task_queue",
+    "//third_party/abseil-cpp/absl/memory",
   ]
 }
 
diff --git a/logging/rtc_event_log/rtc_event_log.cc b/logging/rtc_event_log/rtc_event_log.cc
index 73a598d6b1..b48fe9234f 100644
--- a/logging/rtc_event_log/rtc_event_log.cc
+++ b/logging/rtc_event_log/rtc_event_log.cc
@@ -10,8 +10,14 @@
 
 #include "logging/rtc_event_log/rtc_event_log.h"
 
+#include "absl/memory/memory.h"
+
 namespace webrtc {
 
+std::unique_ptr<RtcEventLog> RtcEventLog::CreateNull() {
+  return absl::make_unique<RtcEventLogNullImpl>();
+}
+
 bool RtcEventLogNullImpl::StartLogging(
     std::unique_ptr<RtcEventLogOutput> output,
     int64_t output_period_ms) {
diff --git a/logging/rtc_event_log/rtc_event_log_impl.cc b/logging/rtc_event_log/rtc_event_log_impl.cc
index 554a0283fd..b6b04285e4 100644
--- a/logging/rtc_event_log/rtc_event_log_impl.cc
+++ b/logging/rtc_event_log/rtc_event_log_impl.cc
@@ -372,8 +372,4 @@ std::unique_ptr<RtcEventLog> RtcEventLog::Create(
 #endif  // ENABLE_RTC_EVENT_LOG
 }
 
-std::unique_ptr<RtcEventLog> RtcEventLog::CreateNull() {
-  return std::unique_ptr<RtcEventLog>(new RtcEventLogNullImpl());
-}
-
 }  // namespace webrtc