admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dcsctp: Use correct field width for PPID

Browse Source 
When migrating to use StrongAlias types, the PPID was incorrectly
modeled as an uint16_t instead of a uint32_t, as it was prior to using
StrongAlias. Most likely a copy-paste error from StreamID.

As the Data Channel PPIDs are in the range of 51-57, it was never caught
in tests.

Bug: webrtc:12614
Change-Id: I2b61ef7935df1222068e7f4e70fc2aaa532dcf7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214960
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33687}
This commit is contained in:
Victor Boivie 2021-04-11 20:44:54 +02:00 committed by Commit Bot
parent 9d60936048
commit 606bd6d163
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/dcsctp/public/types.h
View File

@ -19,7 +19,7 @@ namespace dcsctp {
using StreamID = StrongAlias<class StreamIDTag, uint16_t>;
// Payload Protocol Identifier (PPID)
using PPID = StrongAlias<class PPIDTag, uint16_t>;
using PPID = StrongAlias<class PPIDTag, uint32_t>;
// Timeout Identifier
using TimeoutID = StrongAlias<class TimeoutTag, uint64_t>;