From 5e8351b325bb8a4bdabccea8b66626b6639d5f96 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Bostr=C3=B6m?= Date: Thu, 28 Jan 2016 23:55:29 +0100 Subject: [PATCH] Prevent division-by-zero in VCMFecMethod. Clamps frameRate to at least 1.0 to prevent a zero division. BUG=webrtc:5124 R=stefan@webrtc.org Review URL: https://codereview.webrtc.org/1642903002 . Cr-Commit-Position: refs/heads/master@{#11421} --- webrtc/modules/video_coding/media_opt_util.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/webrtc/modules/video_coding/media_opt_util.cc b/webrtc/modules/video_coding/media_opt_util.cc index d57e9c8dd2..69cf757f2b 100644 --- a/webrtc/modules/video_coding/media_opt_util.cc +++ b/webrtc/modules/video_coding/media_opt_util.cc @@ -434,6 +434,8 @@ int VCMFecMethod::BitsPerFrame(const VCMProtectionParameters* parameters) { // TODO(mikhal): Update factor following testing. float adjustmentFactor = 1; + if (frameRate < 1.0f) + frameRate = 1.0f; // Average bits per frame (units of kbits) return static_cast(adjustmentFactor * bitRate / frameRate); }