From 5e5f7e14b23ee93fb163d64229da5ec5708f7cf9 Mon Sep 17 00:00:00 2001 From: brucedawson Date: Sat, 24 Jun 2017 13:04:29 -0700 Subject: [PATCH] Remove unneeded enum forward declaration While building Chrome with the VC++ 2017 /permissive- flag I got a warning about a forward declaration of enum RateControlRegion. Untyped forward declarations of enums are illegal because the compiler doesn't know what size to make them. The only reason this forward declaration is legal is because it isn't needed (the type is already defined). This was found because /permissive- (or, equivalently for this purpose, /w14471) incorrectly fires on this forward declaration even though it is legal. BUG=chromium:736059 Review-Url: https://codereview.webrtc.org/2834753002 Cr-Commit-Position: refs/heads/master@{#18741} --- webrtc/modules/remote_bitrate_estimator/overuse_detector.h | 1 - 1 file changed, 1 deletion(-) diff --git a/webrtc/modules/remote_bitrate_estimator/overuse_detector.h b/webrtc/modules/remote_bitrate_estimator/overuse_detector.h index 03ddb1ee6a..fc1cc152ec 100644 --- a/webrtc/modules/remote_bitrate_estimator/overuse_detector.h +++ b/webrtc/modules/remote_bitrate_estimator/overuse_detector.h @@ -18,7 +18,6 @@ #include "webrtc/typedefs.h" namespace webrtc { -enum RateControlRegion; bool AdaptiveThresholdExperimentIsDisabled();