From 5cd81cbff7201487dc9d7acac98e0beb7d8f6aa5 Mon Sep 17 00:00:00 2001 From: Gustaf Ullberg Date: Tue, 21 Aug 2018 16:50:28 +0200 Subject: [PATCH] AEC3: Disabling explicit handling of microphone gain changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Disables the faster filter adaptation in the event of microphone gain changes as it sometimes impacted transparency negatively. Bug: webrtc:9526,chromium:863826 Change-Id: I48fb6dd45440518aaf94b6469d6bb891247ea4ab Reviewed-on: https://webrtc-review.googlesource.com/95143 Reviewed-by: Per Åhgren Commit-Queue: Gustaf Ullberg Cr-Commit-Position: refs/heads/master@{#24461} --- modules/audio_processing/aec3/main_filter_update_gain.cc | 3 +-- modules/audio_processing/aec3/subtractor.cc | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/modules/audio_processing/aec3/main_filter_update_gain.cc b/modules/audio_processing/aec3/main_filter_update_gain.cc index 6d31ed00c2..4f48cd4748 100644 --- a/modules/audio_processing/aec3/main_filter_update_gain.cc +++ b/modules/audio_processing/aec3/main_filter_update_gain.cc @@ -22,7 +22,6 @@ namespace webrtc { namespace { constexpr float kHErrorInitial = 10000.f; -constexpr float kHErrorGainChange = 10000.f; constexpr int kPoorExcitationCounterInitial = 1000; } // namespace @@ -48,7 +47,7 @@ MainFilterUpdateGain::~MainFilterUpdateGain() {} void MainFilterUpdateGain::HandleEchoPathChange( const EchoPathVariability& echo_path_variability) { if (echo_path_variability.gain_change) { - H_error_.fill(kHErrorGainChange); + // TODO(bugs.webrtc.org/9526) Handle gain changes. } if (echo_path_variability.delay_change != diff --git a/modules/audio_processing/aec3/subtractor.cc b/modules/audio_processing/aec3/subtractor.cc index b2fc993f48..609e8ac7ed 100644 --- a/modules/audio_processing/aec3/subtractor.cc +++ b/modules/audio_processing/aec3/subtractor.cc @@ -153,8 +153,6 @@ void Subtractor::HandleEchoPathChange( } if (echo_path_variability.gain_change && enable_agc_gain_change_response_) { - RTC_LOG(LS_WARNING) << "Resetting main filter adaptation speed due to " - "microphone gain change"; G_main_.HandleEchoPathChange(echo_path_variability); } }