admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not update stats for WebRTC.Call.EstimatedSendBitrateInKbps if we are not sending video.

Browse Source 
This hopefully fixes a UMA stats  regression introduced in 71ee44cc6d

BUG=webrtc:6244
TBR=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2274713002 .

Cr-Commit-Position: refs/heads/master@{#13868}
This commit is contained in:
Per 2016-08-23 22:00:07 +02:00
parent b37c45cadc
commit 5bed20f7c6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/call/call.cc
View File

@ -735,6 +735,12 @@ void Call::OnNetworkChanged(uint32_t target_bitrate_bps, uint8_t fraction_loss,
// Ignore updates where the bitrate is zero because the aggregate network
// state is down.
if (target_bitrate_bps > 0) {
{
ReadLockScoped read_lock(*send_crit_);
// Do not update the stats if we are not sending video.
if (video_send_streams_.empty())
return;
}
rtc::CritScope lock(&bitrate_crit_);
// We only update these stats if we have send streams, and assume that
// OnNetworkChanged is called roughly with a fixed frequency.