From 5afcc9afae6781803fc7eb0dac3bc6141fea7ac3 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Thu, 21 Jul 2022 09:54:42 +0000 Subject: [PATCH] Remove deprecated LogMessage ctor. This ctor has been deprecated for a while and it should be unused by WebRTC clients. Bug: None Change-Id: I7d33ae24eefafe48924011f55fb53150b717d593 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269180 Commit-Queue: Mirko Bonadei Reviewed-by: Tomas Gunnarsson Cr-Commit-Position: refs/heads/main@{#37584} --- rtc_base/logging.cc | 11 ----------- rtc_base/logging.h | 8 -------- 2 files changed, 19 deletions(-) diff --git a/rtc_base/logging.cc b/rtc_base/logging.cc index b93474de3a..acf4263c88 100644 --- a/rtc_base/logging.cc +++ b/rtc_base/logging.cc @@ -182,17 +182,6 @@ LogMessage::LogMessage(const char* file, } #endif -// DEPRECATED. Currently only used by downstream projects that use -// implementation details of logging.h. Work is ongoing to remove those -// dependencies. -LogMessage::LogMessage(const char* file, - int line, - LoggingSeverity sev, - absl::string_view tag) - : LogMessage(file, line, sev) { - print_stream_ << tag << ": "; -} - LogMessage::~LogMessage() { FinishPrintStream(); diff --git a/rtc_base/logging.h b/rtc_base/logging.h index 13738f0d0e..b02639fb4d 100644 --- a/rtc_base/logging.h +++ b/rtc_base/logging.h @@ -435,14 +435,6 @@ class LogMessage { #if defined(WEBRTC_ANDROID) LogMessage(const char* file, int line, LoggingSeverity sev, const char* tag); #endif - // DEPRECATED - DO NOT USE - PLEASE USE THE MACROS INSTEAD OF THE CLASS. - // Android code should use the 'const char*' version since tags are static - // and we want to avoid allocating a std::string copy per log line. - ABSL_DEPRECATED("Use RTC_LOG macros instead of accessing this class directly") - LogMessage(const char* file, - int line, - LoggingSeverity sev, - absl::string_view tag); ~LogMessage(); LogMessage(const LogMessage&) = delete;