From 5aea38c8be6dd8833d004d5139b18660799c5fef Mon Sep 17 00:00:00 2001 From: Alex Loiko Date: Wed, 27 Sep 2017 13:10:28 +0200 Subject: [PATCH] Disabling CallPerfTest.{CaptureNtpTimeWithNetworkDelay,CaptureNtpTimeWithNetworkJitter}. Tests disabled for Mac only. Tests fail in this way on perf bot Mac 10.11: [ RUN ] CallPerfTest.CaptureNtpTimeWithNetworkDelay ../../call/call_perf_tests.cc:407: Failure Value of: std::abs(time_offset_ms) < threshold_ms_ Actual: false Expected: true TBR=stefan@webrtc.org Bug: webrtc:8291 Change-Id: I8d173fcff21f096827f31ddd670b6647796bff4b Reviewed-on: https://webrtc-review.googlesource.com/4041 Commit-Queue: Alex Loiko Reviewed-by: Alex Loiko Cr-Commit-Position: refs/heads/master@{#19995} --- call/call_perf_tests.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/call/call_perf_tests.cc b/call/call_perf_tests.cc index 5dd69bd497..98ebe8b657 100644 --- a/call/call_perf_tests.cc +++ b/call/call_perf_tests.cc @@ -469,6 +469,8 @@ void CallPerfTest::TestCaptureNtpTime(const FakeNetworkPipe::Config& net_config, RunBaseTest(&test); } +// Flaky tests, disabled on Mac due to webrtc:8291. +#if !(defined(WEBRTC_MAC)) TEST_F(CallPerfTest, CaptureNtpTimeWithNetworkDelay) { FakeNetworkPipe::Config net_config; net_config.queue_delay_ms = 100; @@ -491,6 +493,7 @@ TEST_F(CallPerfTest, CaptureNtpTimeWithNetworkJitter) { const int kRunTimeMs = 20000; TestCaptureNtpTime(net_config, kThresholdMs, kStartTimeMs, kRunTimeMs); } +#endif TEST_F(CallPerfTest, ReceivesCpuOveruseAndUnderuse) { // Minimal normal usage at the start, then 30s overuse to allow filter to