admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused PacketOptions::additional_data.

Browse Source 
Bug: none
Change-Id: I642ad5fde070d7c9c708d99ec9a91b28e294d11e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341960
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41863}
This commit is contained in:
philipel 2024-03-06 11:38:01 +01:00 committed by WebRTC LUCI CQ
parent 36e38757d7
commit 5ace0710bf
3 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/call/transport.h
View File

@ -15,8 +15,6 @@
#include <stdint.h> #include <stdint.h>
#include "api/array_view.h" #include "api/array_view.h"
#include "api/ref_counted_base.h"
#include "api/scoped_refptr.h"
namespace webrtc { namespace webrtc {
@ -30,9 +28,6 @@ struct PacketOptions {
// A 16 bits positive id. Negative ids are invalid and should be interpreted // A 16 bits positive id. Negative ids are invalid and should be interpreted
// as packet_id not being set. // as packet_id not being set.
int packet_id = -1; int packet_id = -1;
// Additional data bound to the RTP packet for use in application code,
// outside of WebRTC.
rtc::scoped_refptr<rtc::RefCountedBase> additional_data;
// Whether this is a retransmission of an earlier packet. // Whether this is a retransmission of an earlier packet.
bool is_retransmit = false; bool is_retransmit = false;
bool included_in_feedback = false; bool included_in_feedback = false;

2
modules/rtp_rtcp/source/deprecated/deprecated_rtp_sender_egress.cc
View File

@ -172,8 +172,6 @@ void DEPRECATED_RtpSenderEgress::SendPacket(
AddPacketToTransportFeedback(*packet_id, *packet, pacing_info); AddPacketToTransportFeedback(*packet_id, *packet, pacing_info);
} }
options.additional_data = packet->additional_data();
if (packet->packet_type() != RtpPacketMediaType::kPadding && if (packet->packet_type() != RtpPacketMediaType::kPadding &&
packet->packet_type() != RtpPacketMediaType::kRetransmission) { packet->packet_type() != RtpPacketMediaType::kRetransmission) {
UpdateOnSendPacket(options.packet_id, packet->capture_time().ms(), UpdateOnSendPacket(options.packet_id, packet->capture_time().ms(),

2
modules/rtp_rtcp/source/rtp_sender_egress.cc
View File

@ -257,8 +257,6 @@ void RtpSenderEgress::CompleteSendPacket(const Packet& compound_packet,
AddPacketToTransportFeedback(*packet_id, *packet, pacing_info); AddPacketToTransportFeedback(*packet_id, *packet, pacing_info);
} }
options.additional_data = packet->additional_data();
if (packet->packet_type() != RtpPacketMediaType::kPadding && if (packet->packet_type() != RtpPacketMediaType::kPadding &&
packet->packet_type() != RtpPacketMediaType::kRetransmission && packet->packet_type() != RtpPacketMediaType::kRetransmission &&
send_packet_observer_ != nullptr && packet->capture_time().IsFinite()) { send_packet_observer_ != nullptr && packet->capture_time().IsFinite()) {