From 5abd54166ae76f32496f64e0a5c644e7ba6db976 Mon Sep 17 00:00:00 2001 From: Jonathan Yu Date: Thu, 25 Oct 2018 13:15:17 -0700 Subject: [PATCH] Stop exporting simulcast_encoder_adapter.h in :rtc_internal_video_codecs All dependencies now depend on :rtc_simulcast_encoder_adapter directly. Leaving the simulcast adapter as a dependency of :rtc_internal_video_codecs because it is used by VP8EncoderSimulcastProxy. Bug: webrtc:7925 Change-Id: I536d3d3b80b13529610847f44e62ad702915be60 Reviewed-on: https://webrtc-review.googlesource.com/c/107690 Commit-Queue: Jonathan Yu Reviewed-by: Mirko Bonadei Reviewed-by: Magnus Jedvert Cr-Commit-Position: refs/heads/master@{#25378} --- media/BUILD.gn | 7 ------- 1 file changed, 7 deletions(-) diff --git a/media/BUILD.gn b/media/BUILD.gn index 01345f8f6f..3bce800d97 100644 --- a/media/BUILD.gn +++ b/media/BUILD.gn @@ -214,11 +214,6 @@ rtc_static_library("rtc_internal_video_codecs") { "engine/scopedvideodecoder.h", "engine/scopedvideoencoder.cc", "engine/scopedvideoencoder.h", - - # TODO(bugs.webrtc.org/7925): When downstream projects depend directly on - # :rtc_simulcast_encoder_adapter, remove it from this target's deps, remove - # its deps from this target's deps, and stop exporting this header here. - "engine/simulcast_encoder_adapter.h", "engine/vp8_encoder_simulcast_proxy.cc", "engine/vp8_encoder_simulcast_proxy.h", "engine/webrtcvideodecoderfactory.h", @@ -248,10 +243,8 @@ rtc_static_library("rtc_internal_video_codecs") { "../modules/video_coding:webrtc_vp9", "../rtc_base:checks", "../rtc_base:rtc_base_approved", - "../rtc_base:sequenced_task_checker", "../rtc_base/system:rtc_export", "//third_party/abseil-cpp/absl/strings", - "//third_party/abseil-cpp/absl/types:optional", ] }