admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removes usage audio_device_test_api.

Browse Source 
These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.

NOTRY=TRUE
BUG=webrtc:7250

Review-Url: https://codereview.webrtc.org/2726433003
Cr-Commit-Position: refs/heads/master@{#19522}
This commit is contained in:
henrika 2017-08-25 07:47:31 -07:00 committed by Commit Bot
parent 99b63455b7
commit 5a0c4ed219
4 changed files with 1 additions and 1710 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/BUILD.gn
View File

@ -329,10 +329,7 @@ if (!build_with_chromium) {
deps += [ "modules/video_capture:video_capture_tests" ]
}
if (!is_ios) {
deps += [
"modules/audio_device:audio_device_tests",
"voice_engine:voe_auto_test",
]
deps += [ "voice_engine:voe_auto_test" ]
}
if (rtc_enable_protobuf) {
deps += [

24
webrtc/modules/audio_device/BUILD.gn
View File

@ -318,30 +318,6 @@ if (rtc_include_tests) {
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
if (!is_ios) {
# These tests do not work on ios, see
# https://bugs.chromium.org/p/webrtc/issues/detail?id=4755
rtc_executable("audio_device_tests") {
testonly = true
sources = [
"test/audio_device_test_api.cc",
"test/audio_device_test_defines.h",
]
deps = [
":audio_device",
"../..:webrtc_common",
"../../rtc_base:rtc_base_approved",
"../../system_wrappers",
"../../test:test_main",
"../../test:test_support",
"../rtp_rtcp",
"../utility",
"//testing/gtest",
]
public_configs = [ ":audio_device_config" ]
}
}
}
if (!build_with_chromium && is_android) {

1608
webrtc/modules/audio_device/test/audio_device_test_api.cc
View File

File diff suppressed because it is too large Load Diff

74
webrtc/modules/audio_device/test/audio_device_test_defines.h
View File

@ -1,74 +0,0 @@
/*
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef WEBRTC_AUDIO_DEVICE_AUDIO_DEVICE_TEST_DEFINES_H
#define WEBRTC_AUDIO_DEVICE_AUDIO_DEVICE_TEST_DEFINES_H
#include "webrtc/common_types.h"
#include "webrtc/modules/audio_device/include/audio_device.h"
#ifdef _WIN32
#define MACRO_DEFAULT_DEVICE AudioDeviceModule::kDefaultDevice
#define MACRO_DEFAULT_COMMUNICATION_DEVICE AudioDeviceModule::kDefaultCommunicationDevice
#else
#define MACRO_DEFAULT_DEVICE 0
#define MACRO_DEFAULT_COMMUNICATION_DEVICE 0
#endif
#ifdef ANDROID
#include <android/log.h>
#define LOG_TAG "WebRtc ADM TEST"
#define TEST_LOG(...) __android_log_print(ANDROID_LOG_DEBUG, LOG_TAG, __VA_ARGS__)
#define TEST_LOG_ERROR(...) __android_log_print(ANDROID_LOG_ERROR, LOG_TAG, __VA_ARGS__)
#else
#define TEST_LOG printf
#define TEST_LOG_ERROR(...) fprintf(stderr, __VA_ARGS__)
#endif
static int warningCount = 0;
#define RESET_TEST \
do { \
warningCount = 0; \
} while(0) \
#define PRINT_ERR_MSG(msg) \
do { \
TEST_LOG_ERROR("Error at line %i of %s\n%s", \
__LINE__, __FILE__, msg); \
} while(0)
#define WARNING(expr) \
do { \
if (!(expr)) { \
TEST_LOG_ERROR("WARNING #%d: at line %i\n\n", \
warningCount+1, __LINE__); \
warningCount++; \
} \
} while(0)
#define PRINT_TEST_RESULTS \
do { \
if (warningCount > 0) \
{ \
TEST_LOG(">> %d warnings <<\n\n", \
warningCount); \
} \
} while(0)
// Helper functions
// For iPhone, they are defined in iPhone specific test code.
// For Android, they are defined in API test only (since both
// API and Func tests are built into the same lib).
// For other, they are defined in both API test and Func test.
const char* GetFilename(const char* filename);
const char* GetResource(const char* resource);
#endif // WEBRTC_AUDIO_DEVICE_AUDIO_DEVICE_TEST_DEFINES_H