From 590cf281fb3def59d6f639813691def18ab55370 Mon Sep 17 00:00:00 2001 From: phoglund Date: Thu, 29 Sep 2016 06:27:49 -0700 Subject: [PATCH] Add autothread to pseudo-tcp fuzzer. I think this will make a rtc::Thread object exist for the lifetime of the environment, which will remove some uninteresting crashes. BUG=chrome:648075 Review-Url: https://codereview.webrtc.org/2365373002 Cr-Commit-Position: refs/heads/master@{#14438} --- webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc b/webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc index f373e6cf9f..4e14a13eeb 100644 --- a/webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc +++ b/webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc @@ -11,6 +11,7 @@ #include #include +#include "webrtc/base/thread.h" #include "webrtc/p2p/base/pseudotcp.h" namespace webrtc { @@ -29,10 +30,15 @@ class FakeIPseudoTcpNotify : public cricket::IPseudoTcpNotify { }; struct Environment { - cricket::PseudoTcp* ptcp; - explicit Environment(cricket::IPseudoTcpNotify* notifier) { - ptcp = new cricket::PseudoTcp(notifier, 0); + explicit Environment(cricket::IPseudoTcpNotify* notifier): + ptcp(new cricket::PseudoTcp(notifier, 0)) { } + + cricket::PseudoTcp* const ptcp; + + // We need the thread to avoid some uninteresting crashes, since the + // production code expects there to be a thread object available. + rtc::AutoThread thread; }; Environment* env = new Environment(new FakeIPseudoTcpNotify());