admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "peerconnection: prefer spec names for signaling state"

Browse Source 
This reverts commit f79bfc65e52a35d27cf0db2d212e94043fb44da3.

Reason for revert: Potentially affects Chromium tests, see
failures on https://chromium-review.googlesource.com/c/chromium/src/+/2276338.

Original change's description:
> peerconnection: prefer spec names for signaling state
> 
> Map the internal state names to the spec ones defined in
>   https://w3c.github.io/webrtc-pc/#rtcsignalingstate-enum
> instead of exposing them. This only affects the (not specified)
> error strings.
> 
> Bug: None
> Change-Id: Ib0b35bb3106b1688e8386f6fdd0b8c7fdebaf1dc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178390
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
> Cr-Commit-Position: refs/heads/master@{#31591}

TBR=hbos@webrtc.org,philipp.hancke@googlemail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I6df20c93f6944b819eb11f22ba30c6221de61d79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178560
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31610}
This commit is contained in:
Mirko Bonadei 2020-07-02 07:47:20 +00:00 committed by Commit Bot
parent f2a4ec19d1
commit 58e64bbf3b
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pc/peer_connection.cc
View File

@ -251,23 +251,21 @@ uint32_t ConvertIceTransportTypeToCandidateFilter(
return cricket::CF_NONE;
}
// Map internal signaling state name to spec name:
// https://w3c.github.io/webrtc-pc/#rtcsignalingstate-enum
std::string GetSignalingStateString(
PeerConnectionInterface::SignalingState state) {
switch (state) {
case PeerConnectionInterface::kStable:
return "stable";
return "kStable";
case PeerConnectionInterface::kHaveLocalOffer:
return "have-local-offer";
return "kHaveLocalOffer";
case PeerConnectionInterface::kHaveLocalPrAnswer:
return "have-local-pranswer";
return "kHavePrAnswer";
case PeerConnectionInterface::kHaveRemoteOffer:
return "have-remote-offer";
return "kHaveRemoteOffer";
case PeerConnectionInterface::kHaveRemotePrAnswer:
return "have-remote-pranswer";
return "kHaveRemotePrAnswer";
case PeerConnectionInterface::kClosed:
return "closed";
return "kClosed";
}
RTC_NOTREACHED();
return "";