admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provide Environment to create audio encoders in both prod code paths

Browse Source 
Bug: webrtc:343086059
Change-Id: I4a3e48dcafe99c47f7c9847c5c3994c9c49807c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/355002
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42508}
This commit is contained in:
Danil Chapovalov 2024-06-18 13:02:58 +02:00 committed by WebRTC LUCI CQ
parent fc6df056b6
commit 578905e7ca
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
audio/audio_send_stream.cc
View File

@ -558,9 +558,10 @@ bool AudioSendStream::SetupSendCodec(const Config& new_config) {
const auto& spec = *new_config.send_codec_spec;
RTC_DCHECK(new_config.encoder_factory);
std::unique_ptr<AudioEncoder> encoder =
new_config.encoder_factory->MakeAudioEncoder(
spec.payload_type, spec.format, new_config.codec_pair_id);
std::unique_ptr<AudioEncoder> encoder = new_config.encoder_factory->Create(
env_, spec.format,
{.payload_type = spec.payload_type,
.codec_pair_id = new_config.codec_pair_id});
if (!encoder) {
RTC_DLOG(LS_ERROR) << "Unable to create encoder for "

4
audio/voip/voip_core.cc
View File

@ -380,8 +380,8 @@ VoipResult VoipCore::SetSendCodec(ChannelId channel_id,
return VoipResult::kInvalidArgument;
}
auto encoder = encoder_factory_->MakeAudioEncoder(
payload_type, encoder_format, absl::nullopt);
auto encoder = encoder_factory_->Create(env_, encoder_format,
{.payload_type = payload_type});
channel->SetEncoder(payload_type, encoder_format, std::move(encoder));
return VoipResult::kOk;