From 572280fe6af771ae1374c0b50c9285b875bb6715 Mon Sep 17 00:00:00 2001 From: Emil Vardar Date: Tue, 27 Aug 2024 13:48:31 +0000 Subject: [PATCH] Remove redundant mapping. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It looks like the map `content_specific_stats_` is just carried over into `aggregated_stats` without doing any important processing. This seems to be redundant and hence, removing it in this CL. Bug: None Change-Id: Ia4a5de03999ecd33d387014928cba322bb11ee93 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360745 Commit-Queue: Emil Vardar (xWF) Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/main@{#42870} --- video/receive_statistics_proxy.cc | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/video/receive_statistics_proxy.cc b/video/receive_statistics_proxy.cc index b5c03bf8b9..05dafbdab4 100644 --- a/video/receive_statistics_proxy.cc +++ b/video/receive_statistics_proxy.cc @@ -234,18 +234,7 @@ void ReceiveStatisticsProxy::UpdateHistograms( if (delay_ms) RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.OnewayDelayInMs", *delay_ms); - // Aggregate content_specific_stats_ by removing experiment or simulcast - // information; - std::map aggregated_stats; for (const auto& it : content_specific_stats_) { - // Calculate simulcast specific metrics (".S0" ... ".S2" suffixes). - VideoContentType content_type = it.first; - // Calculate aggregated metrics (no suffixes. Aggregated on everything). - content_type = it.first; - aggregated_stats[content_type].Add(it.second); - } - - for (const auto& it : aggregated_stats) { // For the metric Foo we report the following slices: // WebRTC.Video.Foo, // WebRTC.Video.Screenshare.Foo,