Revert "Make some more targets publicly visible"
This reverts commit 60d179256213c7516808aff827637cab8a47de89.
Reason for revert:
Breaks Chrome FYI:
/b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
-> returned 1
ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
static_library(target_name) {
^----------------------------
The item //content/renderer:renderer
can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
//third_party/webrtc/*
//third_party/webrtc_overrides/*
]
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout
Original change's description:
> Make some more targets publicly visible
>
> To fix build errors introduced by
> https://webrtc-review.googlesource.com/c/src/+/24140
>
> BUG=webrtc:8254
> NOTRY=true
>
> Change-Id: I9cdf9cee39735368af78291134dbad70aebb7195
> Reviewed-on: https://webrtc-review.googlesource.com/38660
> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21552}
TBR=mbonadei@webrtc.org,kwiberg@webrtc.org
Change-Id: I475ac382218fa77d33abc595f0773275d715a28e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38740
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21554}
This commit is contained in:
parent
b84a90985b
commit
55d1809d0d
@ -139,7 +139,6 @@ rtc_static_library("rtc_constants") {
|
||||
}
|
||||
|
||||
rtc_static_library("rtc_internal_video_codecs") {
|
||||
visibility = [ "*" ]
|
||||
defines = []
|
||||
libs = []
|
||||
deps = [
|
||||
|
||||
@ -13,7 +13,6 @@ import("../../webrtc.gni")
|
||||
# 'video_capture_internal_impl' depending on whether they want to
|
||||
# use the internal capturer.
|
||||
rtc_static_library("video_capture_module") {
|
||||
visibility = [ "*" ]
|
||||
sources = [
|
||||
"device_info_impl.cc",
|
||||
"device_info_impl.h",
|
||||
|
||||
@ -199,7 +199,6 @@ if (!build_with_chromium) {
|
||||
}
|
||||
|
||||
rtc_static_library("event_log_visualizer_utils") {
|
||||
visibility = [ "*" ]
|
||||
sources = [
|
||||
"event_log_visualizer/analyzer.cc",
|
||||
"event_log_visualizer/analyzer.h",
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user