From 54f5a2642135da29fcdb5c9d10417a87778321f4 Mon Sep 17 00:00:00 2001 From: sakal Date: Tue, 14 Jun 2016 01:08:17 -0700 Subject: [PATCH] Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. Review-Url: https://codereview.webrtc.org/2049933004 Cr-Commit-Position: refs/heads/master@{#13120} --- .../src/org/appspot/apprtc/PeerConnectionClient.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java b/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java index 94b66a769f..8b4f17c613 100644 --- a/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java +++ b/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java @@ -286,8 +286,13 @@ public class PeerConnectionClient { executor.execute(new Runnable() { @Override public void run() { - createMediaConstraintsInternal(); - createPeerConnectionInternal(renderEGLContext); + try { + createMediaConstraintsInternal(); + createPeerConnectionInternal(renderEGLContext); + } catch (Exception e) { + reportError("Failed to create peer connection: " + e.getMessage()); + throw e; + } } }); }