From 54dbc3be3fdbb77554d47a4bcede94f6cb8ad602 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Thu, 11 Mar 2021 09:00:15 +0000 Subject: [PATCH] Revert "[Battery]: Delay start of TaskQueuePacedSender." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 89cb65ed663a9000b9f7c90a78039bd85731e9ae. Reason for revert: Breaks downstream project Original change's description: > [Battery]: Delay start of TaskQueuePacedSender. > > To avoid unnecessary repeating tasks, TaskQueuePacedSender is started > only upon RtpTransportControllerSend::EnsureStarted(). > > More specifically, the repeating task happens in > TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self > task_queue_.PostDelayedTask(). > > Bug: chromium:1152887 > Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560 > Commit-Queue: Etienne Pierre-Doray > Reviewed-by: Henrik Boström > Reviewed-by: Erik Språng > Cr-Commit-Position: refs/heads/master@{#33421} Bug: chromium:1152887 Change-Id: I781d3bf614d5d0c03f292c0e478f24ede91624bb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211345 Reviewed-by: Artem Titov Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/master@{#33430} --- call/rtp_transport_controller_send.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/call/rtp_transport_controller_send.cc b/call/rtp_transport_controller_send.cc index de007428f7..f5adae68ae 100644 --- a/call/rtp_transport_controller_send.cc +++ b/call/rtp_transport_controller_send.cc @@ -133,6 +133,9 @@ RtpTransportControllerSend::RtpTransportControllerSend( initial_config_.key_value_config = trials; RTC_DCHECK(bitrate_config.start_bitrate_bps > 0); + pacer()->SetPacingRates( + DataRate::BitsPerSec(bitrate_config.start_bitrate_bps), DataRate::Zero()); + if (absl::StartsWith(trials->Lookup("WebRTC-LazyPacerStart"), "Disabled")) { EnsureStarted(); } @@ -495,10 +498,6 @@ void RtpTransportControllerSend::IncludeOverheadInPacedSender() { void RtpTransportControllerSend::EnsureStarted() { if (!use_task_queue_pacer_ && !process_thread_started_) { process_thread_started_ = true; - pacer()->SetPacingRates( - DataRate::BitsPerSec( - bitrate_configurator_.GetConfig().start_bitrate_bps), - DataRate::Zero()); process_thread_->Start(); } }