From 54daa3ac4df4f467f8cc28d54c21cbd3f8e58bbe Mon Sep 17 00:00:00 2001 From: Lu Liu Date: Wed, 21 Feb 2018 19:37:53 +0000 Subject: [PATCH] Revert "Comment out DCHECK in dtor of VCMDecodedFrameCallback." This reverts commit 9f016a0eb01db60c55dad640ddc03562d88cc087. Reason for revert: Breaking internal project Original change's description: > Comment out DCHECK in dtor of VCMDecodedFrameCallback. > Looking into the downstream issue now. > > NoTry: true > Tbr: ossu@webrtc.org > Bug: webrtc:7361, webrtc:8907, chromium:695438 > Change-Id: Ib52b86cf26401c490b415b151916ec35f0716345 > Reviewed-on: https://webrtc-review.googlesource.com/56042 > Reviewed-by: Tommi > Commit-Queue: Tommi > Cr-Commit-Position: refs/heads/master@{#22122} TBR=ossu@webrtc.org,tommi@webrtc.org Change-Id: I096205c1fe70131f6e1c866411f8838e12eafa92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:7361, webrtc:8907, chromium:695438 Reviewed-on: https://webrtc-review.googlesource.com/56281 Reviewed-by: Lu Liu Commit-Queue: Lu Liu Cr-Commit-Position: refs/heads/master@{#22142} --- modules/video_coding/generic_decoder.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/video_coding/generic_decoder.cc b/modules/video_coding/generic_decoder.cc index 5d22ffacc9..fe6899858d 100644 --- a/modules/video_coding/generic_decoder.cc +++ b/modules/video_coding/generic_decoder.cc @@ -34,8 +34,7 @@ VCMDecodedFrameCallback::VCMDecodedFrameCallback(VCMTiming* timing, } VCMDecodedFrameCallback::~VCMDecodedFrameCallback() { - // TODO(tommi): Re-enable this DCHECK once downstream issues have been fixed. - // RTC_DCHECK(construction_thread_.CalledOnValidThread()); + RTC_DCHECK(construction_thread_.CalledOnValidThread()); } void VCMDecodedFrameCallback::SetUserReceiveCallback(