From 54891af88d125e846f693cd2ad6882088c45d8d6 Mon Sep 17 00:00:00 2001 From: Yves Gerey Date: Mon, 13 Jan 2020 10:09:10 +0100 Subject: [PATCH] More lenient double comparison for RunningStatistics.FullSimpleTest The test was failing (in a flaky fashion, interestingly), comparing: * 50.5 whose mantissa is: 1001010000000000000000000000000000000000000000000000 * with 50.500000000000036 whose mantissa is: 1001010000000000000000000000000000000000000000000101 since EXPECT_DOUBLE_EQ() only allows 4 ULPs difference. We don't need this kind of precision. Bug: webrtc:11134 Change-Id: I811178b0762dbcd61d4f2d3f047ea0b59847fa57 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165761 Reviewed-by: Karl Wiberg Commit-Queue: Yves Gerey Cr-Commit-Position: refs/heads/master@{#30230} --- rtc_base/numerics/running_statistics_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rtc_base/numerics/running_statistics_unittest.cc b/rtc_base/numerics/running_statistics_unittest.cc index 8ef30f1dba..26dc7133e0 100644 --- a/rtc_base/numerics/running_statistics_unittest.cc +++ b/rtc_base/numerics/running_statistics_unittest.cc @@ -62,7 +62,8 @@ TEST(RunningStatistics, FullSimpleTest) { EXPECT_DOUBLE_EQ(*stats.GetMin(), 1.0); EXPECT_DOUBLE_EQ(*stats.GetMax(), 100.0); - EXPECT_DOUBLE_EQ(*stats.GetMean(), 50.5); + // EXPECT_DOUBLE_EQ is too strict (max 4 ULP) for this one. + ASSERT_NEAR(*stats.GetMean(), 50.5, 1e-10); } TEST(RunningStatistics, VarianceAndDeviation) {