From 5481784385e4af0cef2df63bf9aa68ba0c45ccf7 Mon Sep 17 00:00:00 2001 From: Bjorn Terelius Date: Mon, 2 Nov 2020 15:13:12 +0100 Subject: [PATCH] Add kill-switch to RTC event log factory. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:12084 Change-Id: Iac2c05b59a20e272fe302a5580357f6f141dc328 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190983 Reviewed-by: Christoffer Rodbro Reviewed-by: Elad Alon Commit-Queue: Björn Terelius Cr-Commit-Position: refs/heads/master@{#32558} --- api/rtc_event_log/BUILD.gn | 1 + api/rtc_event_log/rtc_event_log_factory.cc | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/api/rtc_event_log/BUILD.gn b/api/rtc_event_log/BUILD.gn index e853058e25..158dc06a7b 100644 --- a/api/rtc_event_log/BUILD.gn +++ b/api/rtc_event_log/BUILD.gn @@ -37,6 +37,7 @@ rtc_library("rtc_event_log_factory") { ":rtc_event_log", "../../rtc_base:checks", "../../rtc_base/system:rtc_export", + "../../system_wrappers:field_trial", "../task_queue", ] diff --git a/api/rtc_event_log/rtc_event_log_factory.cc b/api/rtc_event_log/rtc_event_log_factory.cc index 2013584399..fdf267b7ba 100644 --- a/api/rtc_event_log/rtc_event_log_factory.cc +++ b/api/rtc_event_log/rtc_event_log_factory.cc @@ -14,6 +14,7 @@ #include #include "rtc_base/checks.h" +#include "system_wrappers/include/field_trial.h" #ifdef WEBRTC_ENABLE_RTC_EVENT_LOG #include "logging/rtc_event_log/rtc_event_log_impl.h" @@ -29,6 +30,9 @@ RtcEventLogFactory::RtcEventLogFactory(TaskQueueFactory* task_queue_factory) std::unique_ptr RtcEventLogFactory::CreateRtcEventLog( RtcEventLog::EncodingType encoding_type) { #ifdef WEBRTC_ENABLE_RTC_EVENT_LOG + if (field_trial::IsEnabled("WebRTC-RtcEventLogKillSwitch")) { + return std::make_unique(); + } return std::make_unique(encoding_type, task_queue_factory_); #else return std::make_unique();