admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup temporary files created by tests.

Browse Source 
This CL removes some temporary files created by OptionsFileTest and
TransientFileUtilsTest.

BUG=

Review URL: https://codereview.webrtc.org/1688553002

Cr-Commit-Position: refs/heads/master@{#11554}
This commit is contained in:
jbauch 2016-02-10 09:09:54 -08:00 committed by Commit bot
parent 448468d575
commit 541f1869ca
2 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/base/optionsfile_unittest.cc
View File

@ -42,6 +42,10 @@ class OptionsFileTest : public testing::Test {
OpenStore();
}
~OptionsFileTest() override {
remove(test_file_.c_str());
}
protected:
void OpenStore() {
store_.reset(new OptionsFile(test_file_));

29
webrtc/modules/audio_processing/transient/file_utils_unittest.cc
View File

@ -12,6 +12,7 @@
#include <string.h>
#include <string>
#include <vector>
#include "testing/gtest/include/gtest/gtest.h"
#include "webrtc/base/scoped_ptr.h"
@ -45,6 +46,25 @@ class TransientFileUtilsTest: public ::testing::Test {
kTestFileNamef(
test::ResourcePath("audio_processing/transient/float-utils",
"dat")) {}
~TransientFileUtilsTest() override {
CleanupTempFiles();
}
std::string CreateTempFilename(const std::string& dir,
const std::string& prefix) {
std::string filename = test::TempFilename(dir, prefix);
temp_filenames_.push_back(filename);
return filename;
}
void CleanupTempFiles() {
for (const std::string& filename : temp_filenames_) {
remove(filename.c_str());
}
temp_filenames_.clear();
}
// This file (used in some tests) contains binary data. The data correspond to
// the double representation of the constants: Pi, E, and the Avogadro's
// Number;
@ -56,6 +76,9 @@ class TransientFileUtilsTest: public ::testing::Test {
// Number;
// appended in that order.
const std::string kTestFileNamef;
// List of temporary filenames created by CreateTempFilename.
std::vector<std::string> temp_filenames_;
};
#if defined(WEBRTC_IOS)
@ -358,7 +381,7 @@ TEST_F(TransientFileUtilsTest, MAYBE_ReadDoubleBufferFromFile) {
TEST_F(TransientFileUtilsTest, MAYBE_WriteInt16BufferToFile) {
rtc::scoped_ptr<FileWrapper> file(FileWrapper::Create());
std::string kOutFileName = test::TempFilename(test::OutputPath(),
std::string kOutFileName = CreateTempFilename(test::OutputPath(),
"utils_test");
file->OpenFile(kOutFileName.c_str(),
@ -405,7 +428,7 @@ TEST_F(TransientFileUtilsTest, MAYBE_WriteInt16BufferToFile) {
TEST_F(TransientFileUtilsTest, MAYBE_WriteFloatBufferToFile) {
rtc::scoped_ptr<FileWrapper> file(FileWrapper::Create());
std::string kOutFileName = test::TempFilename(test::OutputPath(),
std::string kOutFileName = CreateTempFilename(test::OutputPath(),
"utils_test");
file->OpenFile(kOutFileName.c_str(),
@ -452,7 +475,7 @@ TEST_F(TransientFileUtilsTest, MAYBE_WriteFloatBufferToFile) {
TEST_F(TransientFileUtilsTest, MAYBE_WriteDoubleBufferToFile) {
rtc::scoped_ptr<FileWrapper> file(FileWrapper::Create());
std::string kOutFileName = test::TempFilename(test::OutputPath(),
std::string kOutFileName = CreateTempFilename(test::OutputPath(),
"utils_test");
file->OpenFile(kOutFileName.c_str(),