admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused RemoteBitrateEstimator::IncomingPacketFeedbackVector()

Browse Source 
BUG=None

Review-Url: https://codereview.webrtc.org/2721463003
Cr-Commit-Position: refs/heads/master@{#17058}
This commit is contained in:
elad.alon 2017-03-06 03:11:06 -08:00 committed by Commit bot
parent dea7f4f46f
commit 5419ac8c02
6 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h
View File

@ -26,8 +26,6 @@ class MockRemoteBitrateObserver : public RemoteBitrateObserver {
class MockRemoteBitrateEstimator : public RemoteBitrateEstimator {
public:
MOCK_METHOD1(IncomingPacketFeedbackVector,
void(const std::vector<PacketInfo>&));
MOCK_METHOD3(IncomingPacket, void(int64_t, size_t, const RTPHeader&));
MOCK_METHOD1(RemoveStream, void(uint32_t));
MOCK_CONST_METHOD2(LatestEstimate, bool(std::vector<uint32_t>*, uint32_t*));

5
webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
View File

@ -46,11 +46,6 @@ class RemoteBitrateEstimator : public CallStatsObserver, public Module {
public:
virtual ~RemoteBitrateEstimator() {}
virtual void IncomingPacketFeedbackVector(
const std::vector<PacketInfo>& packet_feedback_vector) {
assert(false);
}
// Called for each incoming packet. Updates the incoming payload bitrate
// estimate and the over-use detector. If an over-use is detected the
// remote bitrate estimate will be updated. Note that |payload_size| is the

10
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
View File

@ -208,16 +208,6 @@ bool RemoteBitrateEstimatorAbsSendTime::IsBitrateImproving(
return initial_probe || bitrate_above_estimate;
}
void RemoteBitrateEstimatorAbsSendTime::IncomingPacketFeedbackVector(
const std::vector<PacketInfo>& packet_feedback_vector) {
RTC_DCHECK(network_thread_.CalledOnValidThread());
for (const auto& packet_info : packet_feedback_vector) {
IncomingPacketInfo(packet_info.arrival_time_ms,
ConvertMsTo24Bits(packet_info.send_time_ms),
packet_info.payload_size, 0);
}
}
void RemoteBitrateEstimatorAbsSendTime::IncomingPacket(
int64_t arrival_time_ms,
size_t payload_size,

3
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h
View File

@ -72,9 +72,6 @@ class RemoteBitrateEstimatorAbsSendTime : public RemoteBitrateEstimator {
Clock* clock);
virtual ~RemoteBitrateEstimatorAbsSendTime() {}
void IncomingPacketFeedbackVector(
const std::vector<PacketInfo>& packet_feedback_vector) override;
void IncomingPacket(int64_t arrival_time_ms,
size_t payload_size,
const RTPHeader& header) override;

7
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc
View File

@ -45,13 +45,6 @@ RemoteEstimatorProxy::RemoteEstimatorProxy(Clock* clock,
RemoteEstimatorProxy::~RemoteEstimatorProxy() {}
void RemoteEstimatorProxy::IncomingPacketFeedbackVector(
const std::vector<PacketInfo>& packet_feedback_vector) {
rtc::CritScope cs(&lock_);
for (PacketInfo info : packet_feedback_vector)
OnPacketArrival(info.sequence_number, info.arrival_time_ms);
}
void RemoteEstimatorProxy::IncomingPacket(int64_t arrival_time_ms,
size_t payload_size,
const RTPHeader& header) {

2
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h
View File

@ -35,8 +35,6 @@ class RemoteEstimatorProxy : public RemoteBitrateEstimator {
RemoteEstimatorProxy(Clock* clock, PacketRouter* packet_router);
virtual ~RemoteEstimatorProxy();
void IncomingPacketFeedbackVector(
const std::vector<PacketInfo>& packet_feedback_vector) override;
void IncomingPacket(int64_t arrival_time_ms,
size_t payload_size,
const RTPHeader& header) override;