admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[infra] Add Reclient shadow builders as experimental

Browse Source 
The reclient CQ builders work as expected.

https://ci.chromium.org/ui/p/webrtc/builders/try/android_arm_rel_reclient/14/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/ios_compile_arm64_rel_reclient/11/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/linux_rel_reclient/15/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/mac_rel_reclient/12/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/win_compile_x64_clang_rel_reclient/11/overview

This CL allows those builders run as part of CQ, but as experimental.

Setting `experiment_percentage` make the builders non-blocking.
See also https://chromium.googlesource.com/infra/luci/luci-go/+/HEAD/lucicfg/doc/README.md#luci.cq-tryjob-verifier-args

Considering the volume of WebRTC CQ, it's probably fine to shadow all builds to collect data quickly.
If it causes bot shortage, please decrease the percentage so that they don't always run.

Bug: b/243594984
Change-Id: Id9ab422c0d3e37c11e0d787f2fe6145c80c2f384
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286760
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38833}
This commit is contained in:
Junji Watanabe 2022-12-07 17:13:15 +09:00 committed by WebRTC LUCI CQ
parent f1da1d5e53
commit 53f3049588
2 changed files with 54 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
infra/config/commit-queue.cfg
View File

@ -46,12 +46,20 @@ config_groups {
builders {
name: "webrtc/try/android_arm_rel"
}
builders {
name: "webrtc/try/android_arm_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/android_chromium_compile"
}
builders {
name: "webrtc/try/android_compile_arm64_rel"
}
builders {
name: "webrtc/try/android_compile_arm_dbg"
experiment_percentage: 100
}
builders {
name: "webrtc/try/android_compile_arm_rel"
}
@ -73,6 +81,10 @@ config_groups {
builders {
name: "webrtc/try/ios_compile_arm64_rel"
}
builders {
name: "webrtc/try/ios_compile_arm64_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/ios_sim_x64_dbg_ios12"
}
@ -121,6 +133,10 @@ config_groups {
builders {
name: "webrtc/try/linux_rel"
}
builders {
name: "webrtc/try/linux_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/linux_tsan2"
}
@ -154,6 +170,10 @@ config_groups {
builders {
name: "webrtc/try/mac_rel_m1"
}
builders {
name: "webrtc/try/mac_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/presubmit"
disable_reuse: true
@ -173,6 +193,10 @@ config_groups {
builders {
name: "webrtc/try/win_compile_x64_clang_rel"
}
builders {
name: "webrtc/try/win_compile_x64_clang_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/win_compile_x86_clang_dbg"
}
@ -219,9 +243,17 @@ config_groups {
builders {
name: "webrtc/try/android_arm_rel"
}
builders {
name: "webrtc/try/android_arm_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/android_compile_arm64_rel"
}
builders {
name: "webrtc/try/android_compile_arm_dbg"
experiment_percentage: 100
}
builders {
name: "webrtc/try/android_compile_arm_rel"
}
@ -243,6 +275,10 @@ config_groups {
builders {
name: "webrtc/try/ios_compile_arm64_rel"
}
builders {
name: "webrtc/try/ios_compile_arm64_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/ios_sim_x64_dbg_ios12"
}
@ -285,6 +321,10 @@ config_groups {
builders {
name: "webrtc/try/linux_rel"
}
builders {
name: "webrtc/try/linux_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/linux_tsan2"
}
@ -315,6 +355,10 @@ config_groups {
builders {
name: "webrtc/try/mac_rel_m1"
}
builders {
name: "webrtc/try/mac_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/presubmit"
disable_reuse: true
@ -328,6 +372,10 @@ config_groups {
builders {
name: "webrtc/try/win_compile_x64_clang_rel"
}
builders {
name: "webrtc/try/win_compile_x64_clang_rel_reclient"
experiment_percentage: 100
}
builders {
name: "webrtc/try/win_compile_x86_clang_dbg"
}

12
infra/config/config.star
View File

@ -709,11 +709,11 @@ ios_builder, ios_try_job = normal_builder_factory(
# Actual builder configuration:
android_builder("Android32 (dbg)", "Android|arm|dbg")
android_try_job("android_compile_arm_dbg", cq = None)
android_try_job("android_compile_arm_dbg", cq = {"experiment_percentage": 100})
android_try_job("android_arm_dbg")
android_builder("Android32", "Android|arm|rel")
android_try_job("android_arm_rel")
android_try_job("android_arm_rel_reclient", cq = None)
android_try_job("android_arm_rel_reclient", cq = {"experiment_percentage": 100})
android_builder("Android32 Builder arm", "Android|arm|size", perf_cat = "Android|arm|Builder|", prioritized = True)
android_try_job("android_compile_arm_rel")
perf_builder("Perf Android32 (M Nexus5)", "Android|arm|Tester|M Nexus5", triggered_by = ["Android32 Builder arm"])
@ -744,7 +744,7 @@ ios_builder("iOS64 Debug", "iOS|arm64|dbg")
ios_try_job("ios_compile_arm64_dbg")
ios_builder("iOS64 Release", "iOS|arm64|rel")
ios_try_job("ios_compile_arm64_rel")
ios_try_job("ios_compile_arm64_rel_reclient", cq = None)
ios_try_job("ios_compile_arm64_rel_reclient", cq = {"experiment_percentage": 100})
ios_builder("iOS64 Sim Debug (iOS 14)", "iOS|x64|14")
ios_try_job("ios_sim_x64_dbg_ios14")
ios_builder("iOS64 Sim Debug (iOS 13)", "iOS|x64|13")
@ -763,7 +763,7 @@ linux_try_job("linux_dbg", cq = None)
linux_try_job("linux_compile_dbg")
linux_builder("Linux64 Release", "Linux|x64|rel")
linux_try_job("linux_rel")
linux_try_job("linux_rel_reclient", cq = None)
linux_try_job("linux_rel_reclient", cq = {"experiment_percentage": 100})
linux_builder("Linux64 Builder", "Linux|x64|size", perf_cat = "Linux|x64|Builder|", prioritized = True)
linux_try_job("linux_compile_rel")
perf_builder("Perf Linux Bionic", "Linux|x64|Tester|Bionic", triggered_by = ["Linux64 Builder"])
@ -804,7 +804,7 @@ mac_try_job("mac_compile_dbg")
mac_builder("Mac64 Release", "Mac|x64|rel")
mac_try_job("mac_rel")
mac_try_job("mac_rel_reclient", cq = None)
mac_try_job("mac_rel_reclient", cq = {"experiment_percentage": 100})
mac_try_job("mac_compile_rel", cq = None)
mac_builder("Mac64 Builder", ci_cat = None, perf_cat = "Mac|x64|Builder|")
mac_builder("MacArm64 Builder", ci_cat = None, perf_cat = "Mac|arm64|Builder|")
@ -832,7 +832,7 @@ win_try_job("win_compile_x64_clang_dbg")
win_builder("Win64 Release (Clang)", "Win Clang|x64|rel")
win_try_job("win_x64_clang_rel", cq = None)
win_try_job("win_compile_x64_clang_rel")
win_try_job("win_compile_x64_clang_rel_reclient", cq = None)
win_try_job("win_compile_x64_clang_rel_reclient", cq = {"experiment_percentage": 100})
win_builder("Win64 ASan", "Win Clang|x64|asan")
win_try_job("win_asan")
win_builder("Win (more configs)", "Win Clang|x86|more")