admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update comments for removal of MediaController.

Browse Source 
Comment-only changes.

TBR=deadbeef@webrtc.org
BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2869703002
Cr-Commit-Position: refs/heads/master@{#18045}
This commit is contained in:
nisse 2017-05-08 03:21:43 -07:00 committed by Commit bot
parent fc0acc44e6
commit 528b7931f8
3 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/media/base/mediachannel.h
View File

@ -92,8 +92,7 @@ static T MinPositive(T a, T b) {
return std::min(a, b);
}
// Construction-time settings, passed to
// MediaControllerInterface::Create, and passed on when creating
// Construction-time settings, passed on when creating
// MediaChannels.
struct MediaConfig {
// Set DSCP value on packets. This flag comes from the

2
webrtc/ortc/rtptransportcontrolleradapter.h
View File

@ -34,7 +34,7 @@ class RtpTransportAdapter;
class OrtcRtpSenderAdapter;
class OrtcRtpReceiverAdapter;
// Implementation of RtpTransportControllerInterface. Wraps a MediaController,
// Implementation of RtpTransportControllerInterface. Wraps a Call,
// a VoiceChannel and VideoChannel, and maintains a list of dependent RTP
// transports.
//

16
webrtc/pc/peerconnectioninterface_unittest.cc
View File

@ -634,10 +634,10 @@ class MockPeerConnectionObserver : public PeerConnectionObserver {
} // namespace
// The PeerConnectionMediaConfig tests below verify that configuration
// and constraints are propagated into the MediaConfig passed to
// CreateMediaController. These settings are intended for MediaChannel
// constructors, but that is not exercised by these unittest.
// The PeerConnectionMediaConfig tests below verify that configuration and
// constraints are propagated into the PeerConnection's MediaConfig. These
// settings are intended for MediaChannel constructors, but that is not
// exercised by these unittest.
class PeerConnectionFactoryForTest : public webrtc::PeerConnectionFactory {
public:
PeerConnectionFactoryForTest()
@ -3333,7 +3333,7 @@ TEST_F(PeerConnectionMediaConfigTest, TestDefaults) {
}
// This test verifies the DSCP constraint is recognized and passed to
// the CreateMediaController call.
// the PeerConnection.
TEST_F(PeerConnectionMediaConfigTest, TestDscpConstraintTrue) {
PeerConnectionInterface::RTCConfiguration config;
FakeConstraints constraints;
@ -3346,7 +3346,7 @@ TEST_F(PeerConnectionMediaConfigTest, TestDscpConstraintTrue) {
}
// This test verifies the cpu overuse detection constraint is
// recognized and passed to the CreateMediaController call.
// recognized and passed to the PeerConnection.
TEST_F(PeerConnectionMediaConfigTest, TestCpuOveruseConstraintFalse) {
PeerConnectionInterface::RTCConfiguration config;
FakeConstraints constraints;
@ -3360,7 +3360,7 @@ TEST_F(PeerConnectionMediaConfigTest, TestCpuOveruseConstraintFalse) {
}
// This test verifies that the disable_prerenderer_smoothing flag is
// propagated from RTCConfiguration to the CreateMediaController call.
// propagated from RTCConfiguration to the PeerConnection.
TEST_F(PeerConnectionMediaConfigTest, TestDisablePrerendererSmoothingTrue) {
PeerConnectionInterface::RTCConfiguration config;
FakeConstraints constraints;
@ -3373,7 +3373,7 @@ TEST_F(PeerConnectionMediaConfigTest, TestDisablePrerendererSmoothingTrue) {
}
// This test verifies the suspend below min bitrate constraint is
// recognized and passed to the CreateMediaController call.
// recognized and passed to the PeerConnection.
TEST_F(PeerConnectionMediaConfigTest,
TestSuspendBelowMinBitrateConstraintTrue) {
PeerConnectionInterface::RTCConfiguration config;