From 521b09bfb720eb9a32d53e90aaf6501249ec445b Mon Sep 17 00:00:00 2001 From: Shunbo Li Date: Thu, 24 Oct 2024 17:06:48 +0800 Subject: [PATCH] Fix regression caused by default action changed for h264:Nalu:kFiller This commit fixes the issue of discontinuous RTP sequence numbers caused by improper discarding of these nalu types: kFiller/kEndofSequence/kEndOfStream. Bug: webrtc:368335257 Change-Id: Id7a2d34b22ee1c6e1523d8279d9838c57fdeb97f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366501 Reviewed-by: Danil Chapovalov Commit-Queue: Sergey Silkin Reviewed-by: Sergey Silkin Cr-Commit-Position: refs/heads/main@{#43299} --- AUTHORS | 1 + modules/rtp_rtcp/source/video_rtp_depacketizer_h264.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/AUTHORS b/AUTHORS index 652e3aec29..716a9c32df 100644 --- a/AUTHORS +++ b/AUTHORS @@ -125,6 +125,7 @@ Sergio Garcia Murillo Shaofan Qi Shigemasa Watanabe Shuhai Peng +Shunbo Li Seija Silviu Caragea Stefan Gula diff --git a/modules/rtp_rtcp/source/video_rtp_depacketizer_h264.cc b/modules/rtp_rtcp/source/video_rtp_depacketizer_h264.cc index 2439c6c16f..97bbe7db24 100644 --- a/modules/rtp_rtcp/source/video_rtp_depacketizer_h264.cc +++ b/modules/rtp_rtcp/source/video_rtp_depacketizer_h264.cc @@ -206,6 +206,7 @@ std::optional ProcessStapAOrSingleNalu( case H264::NaluType::kEndOfSequence: case H264::NaluType::kEndOfStream: case H264::NaluType::kFiller: + break; case H264::NaluType::kStapA: case H264::NaluType::kFuA: RTC_LOG(LS_WARNING) << "Unexpected STAP-A or FU-A received.";