diff --git a/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/modules/rtp_rtcp/source/rtp_rtcp_impl.cc index 52a16ec36d..f3e7e30c7c 100644 --- a/modules/rtp_rtcp/source/rtp_rtcp_impl.cc +++ b/modules/rtp_rtcp/source/rtp_rtcp_impl.cc @@ -444,9 +444,12 @@ bool ModuleRtpRtcpImpl::SupportsRtxPayloadPadding() const { std::vector> ModuleRtpRtcpImpl::GeneratePadding(size_t target_size_bytes) { RTC_DCHECK(rtp_sender_); + // `can_send_padding_on_media_ssrc` set to false but is ignored at this + // point, RTPSender will internally query `sequencer_` while holding the + // send lock. return rtp_sender_->packet_generator.GeneratePadding( target_size_bytes, rtp_sender_->packet_sender.MediaHasBeenSent(), - rtp_sender_->sequencer_.CanSendPaddingOnMediaSsrc()); + /*can_send_padding_on_media_ssrc=*/false); } std::vector diff --git a/modules/rtp_rtcp/source/rtp_rtcp_impl2.cc b/modules/rtp_rtcp/source/rtp_rtcp_impl2.cc index 38fbf4590d..af64ddb269 100644 --- a/modules/rtp_rtcp/source/rtp_rtcp_impl2.cc +++ b/modules/rtp_rtcp/source/rtp_rtcp_impl2.cc @@ -398,9 +398,12 @@ bool ModuleRtpRtcpImpl2::SupportsRtxPayloadPadding() const { std::vector> ModuleRtpRtcpImpl2::GeneratePadding(size_t target_size_bytes) { RTC_DCHECK(rtp_sender_); + // `can_send_padding_on_media_ssrc` set to false but is ignored at this + // point, RTPSender will internally query `sequencer_` while holding the + // send lock. return rtp_sender_->packet_generator.GeneratePadding( target_size_bytes, rtp_sender_->packet_sender.MediaHasBeenSent(), - rtp_sender_->sequencer_.CanSendPaddingOnMediaSsrc()); + /*can_send_padding_on_media_ssrc=*/false); } std::vector