From 50686460caad4d13283c550df01690316e7cb934 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20M=C3=B6ller?= <nisse@webrtc.org>
Date: Tue, 26 Mar 2019 10:36:02 +0100
Subject: [PATCH] Replace RTPHeader memset with assignment from a fresh object.

Since RTPHeader contains std::string members, memset results in
undefined behavior, with memory leaks being the best case.

Bug: chromium:945598
Change-Id: I5c04e6b2fb08816fc036abfbb6ba7aaf19469687
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129720
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27282}
---
 modules/rtp_rtcp/source/rtp_header_parser.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/rtp_rtcp/source/rtp_header_parser.cc b/modules/rtp_rtcp/source/rtp_header_parser.cc
index 1d937f80bd..65431d1397 100644
--- a/modules/rtp_rtcp/source/rtp_header_parser.cc
+++ b/modules/rtp_rtcp/source/rtp_header_parser.cc
@@ -64,7 +64,7 @@ bool RtpHeaderParserImpl::Parse(const uint8_t* packet,
                                 size_t length,
                                 RTPHeader* header) const {
   RtpUtility::RtpHeaderParser rtp_parser(packet, length);
-  memset(header, 0, sizeof(*header));
+  *header = RTPHeader();
 
   RtpHeaderExtensionMap map;
   {