admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Import config.gni from partition_alloc.gni's build_override.

Browse Source 
The file base/allocator/partition_allocator/partition_alloc.gni reads
the variable is_cronet_build, which is defined by the cronet.gni file.

Removing the import and relying on the transitive import from another
.gni file, makes it brittle (e.g. in this case it breaks WebRTC's bots).

Bug: b/344727254
Change-Id: If6c537e934ae4b2243eb104a4b867b49f5d10cca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353540
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42431}
This commit is contained in:
Mirko Bonadei 2024-06-04 11:35:54 +00:00 committed by WebRTC LUCI CQ
parent fe34363ca0
commit 500e1e1c98
1 changed files with 29 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
build_overrides/partition_alloc.gni
View File

@ -6,9 +6,34 @@
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
# Use default values for PartitionAlloc as standalone library from
# base/allocator/partition_allocator/build_overrides/partition_alloc.gni
import(
"//base/allocator/partition_allocator/build_overrides/partition_alloc.gni")
# Dependencies from //build defining variables used by partition_alloc.
import("//build/config/android/config.gni")
import("//build/config/cast.gni")
import("//build/config/chromeos/ui_mode.gni")
import("//build/config/compiler/compiler.gni")
import("//build/config/cronet/config.gni")
import("//build/config/dcheck_always_on.gni")
import("//build/config/logging.gni")
partition_alloc_enable_arc_config = "//build/config/compiler:enable_arc"
# partition_alloc is performance critical and it should generally be optimized
# for speed, even in debug mode. WebRTC doesn't really need its debug version.
partition_alloc_remove_configs =
[ "//build/config/compiler:default_optimization" ]
partition_alloc_add_configs = [ "//build/config/compiler:optimize_speed" ]
# Disable partition_alloc for WebRTC standalone builds.
use_partition_alloc_as_malloc_default = false
use_allocator_shim_default = false
enable_backup_ref_ptr_support_default = false
enable_backup_ref_ptr_slow_checks_default = false
enable_dangling_raw_ptr_checks_default = false
# raw_ptr behave like naked pointers, except they are always initialized. This
# avoids relying on undefined behaviors.
raw_ptr_zero_on_construct_default = true
raw_ptr_zero_on_move_default = true
raw_ptr_zero_on_destruct_default = false
# WebRTC used C++20 by default:
assert_cpp20_default = true