admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove WebRTC-TaskQueuePacer trial.

Browse Source 
Removes the last unused field trial parameters, the legacy pacer code
was removed some time ago so the main flag feature has been a noop
since then.

Bug: None
Change-Id: I5266d54fccb4c5fde05a6895072cd76cd5f7fbd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293349
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39310}
This commit is contained in:
Erik Språng 2023-02-14 16:50:00 +01:00 committed by WebRTC LUCI CQ
parent 2bee5dd4e3
commit 4f642c11f8
2 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
call/rtp_transport_controller_send.cc
View File

@ -70,14 +70,6 @@ bool IsRelayed(const rtc::NetworkRoute& route) {
}
} // namespace
RtpTransportControllerSend::PacerSettings::PacerSettings(
const FieldTrialsView& trials)
: holdback_window("holdback_window", TimeDelta::Millis(5)),
holdback_packets("holdback_packets", 3) {
ParseFieldTrial({&holdback_window, &holdback_packets},
trials.Lookup("WebRTC-TaskQueuePacer"));
}
RtpTransportControllerSend::RtpTransportControllerSend(
Clock* clock,
const RtpTransportConfig& config)
@ -86,13 +78,12 @@ RtpTransportControllerSend::RtpTransportControllerSend(
task_queue_factory_(config.task_queue_factory),
bitrate_configurator_(config.bitrate_config),
pacer_started_(false),
pacer_settings_(*config.trials),
pacer_(clock,
&packet_router_,
*config.trials,
config.task_queue_factory,
pacer_settings_.holdback_window.Get(),
pacer_settings_.holdback_packets.Get(),
TimeDelta::Millis(5),
3,
config.pacer_burst_interval),
observer_(nullptr),
controller_factory_override_(config.network_controller_factory),

8
call/rtp_transport_controller_send.h
View File

@ -123,13 +123,6 @@ class RtpTransportControllerSend final
void OnRemoteNetworkEstimate(NetworkStateEstimate estimate) override;
private:
struct PacerSettings {
explicit PacerSettings(const FieldTrialsView& trials);
FieldTrialParameter<TimeDelta> holdback_window;
FieldTrialParameter<int> holdback_packets;
};
void MaybeCreateControllers() RTC_RUN_ON(task_queue_);
void UpdateInitialConstraints(TargetRateConstraints new_contraints)
RTC_RUN_ON(task_queue_);
@ -159,7 +152,6 @@ class RtpTransportControllerSend final
RtpBitrateConfigurator bitrate_configurator_;
std::map<std::string, rtc::NetworkRoute> network_routes_;
bool pacer_started_;
const PacerSettings pacer_settings_;
TaskQueuePacedSender pacer_;
TargetTransferRateObserver* observer_ RTC_GUARDED_BY(task_queue_);