From 4ef22d1d293fe7b2398e4cd90a0eb2e8fb02b6ea Mon Sep 17 00:00:00 2001 From: "minyue@webrtc.org" Date: Mon, 17 Nov 2014 09:26:39 +0000 Subject: [PATCH] Setting Opus FEC as default BUG=3986 R=mflodman@webrtc.org, tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/26899004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7710 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/media/webrtc/webrtcvoiceengine.cc | 4 +++- talk/media/webrtc/webrtcvoiceengine_unittest.cc | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc index c97ed7509d..c335626dc2 100644 --- a/talk/media/webrtc/webrtcvoiceengine.cc +++ b/talk/media/webrtc/webrtcvoiceengine.cc @@ -541,7 +541,9 @@ void WebRtcVoiceEngine::ConstructCodecs() { codec.params[kCodecParamMaxPTime] = rtc::ToString(kPreferredMaxPTime); } - // TODO(hellner): Add ptime, sprop-stereo, stereo and useinbandfec + codec.SetParam(kCodecParamUseInbandFec, "1"); + + // TODO(hellner): Add ptime, sprop-stereo, and stereo // when they can be set to values other than the default. } codecs_.push_back(codec); diff --git a/talk/media/webrtc/webrtcvoiceengine_unittest.cc b/talk/media/webrtc/webrtcvoiceengine_unittest.cc index 5eb6e24484..cb91723dbc 100644 --- a/talk/media/webrtc/webrtcvoiceengine_unittest.cc +++ b/talk/media/webrtc/webrtcvoiceengine_unittest.cc @@ -3276,6 +3276,8 @@ TEST(WebRtcVoiceEngineTest, HasCorrectCodecs) { EXPECT_EQ("10", it->params.find("minptime")->second); ASSERT_TRUE(it->params.find("maxptime") != it->params.end()); EXPECT_EQ("60", it->params.find("maxptime")->second); + ASSERT_TRUE(it->params.find("useinbandfec") != it->params.end()); + EXPECT_EQ("1", it->params.find("useinbandfec")->second); } }