From 4e7f6c188770765f4dff52d31fb77a6630a51b80 Mon Sep 17 00:00:00 2001 From: kjellander Date: Mon, 25 Apr 2016 21:59:50 -0700 Subject: [PATCH] Add proper dependencies for webrtc/modules/audio_coding/codecs The audio_decoder_interface and audio_encoder_interface targets are depending on rtc_base_approved headers but don't declare such dependencies. NOTRY=True Review URL: https://codereview.webrtc.org/1916953002 Cr-Commit-Position: refs/heads/master@{#12500} --- webrtc/modules/audio_coding/BUILD.gn | 2 ++ webrtc/modules/audio_coding/codecs/interfaces.gypi | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn index 7a0724759f..99fa140da3 100644 --- a/webrtc/modules/audio_coding/BUILD.gn +++ b/webrtc/modules/audio_coding/BUILD.gn @@ -121,6 +121,7 @@ source_set("audio_decoder_interface") { public_configs = [ "../..:common_inherited_config" ] deps = [ "../..:webrtc_common", + "../../base:rtc_base_approved", ] } @@ -133,6 +134,7 @@ source_set("audio_encoder_interface") { public_configs = [ "../..:common_inherited_config" ] deps = [ "../..:webrtc_common", + "../../base:rtc_base_approved", ] } diff --git a/webrtc/modules/audio_coding/codecs/interfaces.gypi b/webrtc/modules/audio_coding/codecs/interfaces.gypi index d4f6a4a41e..1aba106f90 100644 --- a/webrtc/modules/audio_coding/codecs/interfaces.gypi +++ b/webrtc/modules/audio_coding/codecs/interfaces.gypi @@ -15,6 +15,10 @@ 'audio_decoder.cc', 'audio_decoder.h', ], + 'dependencies': [ + '<(webrtc_root)/base/base.gyp:rtc_base_approved', + '<(webrtc_root)/common.gyp:webrtc_common', + ], }, { @@ -24,6 +28,10 @@ 'audio_encoder.cc', 'audio_encoder.h', ], + 'dependencies': [ + '<(webrtc_root)/base/base.gyp:rtc_base_approved', + '<(webrtc_root)/common.gyp:webrtc_common', + ], }, ], }