From 4e34c18c4bbb3f979bb54cf0b1563cdcca5a4272 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pablo=20Barrera=20Gonz=C3=A1lez?= Date: Wed, 29 May 2019 09:24:30 +0200 Subject: [PATCH] Check input file extension is not wav MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is an usual error while using neteq_quality_test. This tool does not support wav files as input. Adding a validation. Bug: webrtc:10690 Change-Id: I18ed308d2f688106728df5df25e0a58c7170f411 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139104 Commit-Queue: Pablo Barrera González Reviewed-by: Henrik Lundin Cr-Commit-Position: refs/heads/master@{#28141} --- modules/audio_coding/neteq/tools/neteq_quality_test.cc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/modules/audio_coding/neteq/tools/neteq_quality_test.cc b/modules/audio_coding/neteq/tools/neteq_quality_test.cc index 54d8bbbe92..81305efe27 100644 --- a/modules/audio_coding/neteq/tools/neteq_quality_test.cc +++ b/modules/audio_coding/neteq/tools/neteq_quality_test.cc @@ -38,8 +38,13 @@ const std::string& DefaultOutFilename() { } // Common validator for file names. -static bool ValidateFilename(const std::string& value, bool write) { - FILE* fid = write ? fopen(value.c_str(), "wb") : fopen(value.c_str(), "rb"); +static bool ValidateFilename(const std::string& value, bool is_output) { + if (!is_output) { + RTC_CHECK_NE(value.substr(value.find_last_of(".") + 1), "wav") + << "WAV file input is not supported"; + } + FILE* fid = + is_output ? fopen(value.c_str(), "wb") : fopen(value.c_str(), "rb"); if (fid == nullptr) return false; fclose(fid);