From 4db97b9063384e24b963d8ef3644faab49594e41 Mon Sep 17 00:00:00 2001 From: Sam Zackrisson Date: Thu, 28 Sep 2017 16:07:41 +0200 Subject: [PATCH] Enable and update some bit exactness tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This enables the bit exactness tests for the audio level controller. Additionally, some expected test values are updated. Bug: webrtc:8309 Change-Id: Ia73f2a16aea4b3e926d70d8b4b8e5d5d801833c7 Reviewed-on: https://webrtc-review.googlesource.com/4426 Reviewed-by: Per Ã…hgren Commit-Queue: Sam Zackrisson Cr-Commit-Position: refs/heads/master@{#20102} --- .../level_controller_unittest.cc | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/modules/audio_processing/level_controller/level_controller_unittest.cc b/modules/audio_processing/level_controller/level_controller_unittest.cc index a36f12c5f3..837cfc3928 100644 --- a/modules/audio_processing/level_controller/level_controller_unittest.cc +++ b/modules/audio_processing/level_controller/level_controller_unittest.cc @@ -88,19 +88,19 @@ TEST(LevelControllerConfig, ToString) { LevelController::ToString(config.level_controller)); } -TEST(LevelControlBitExactnessTest, DISABLED_Mono8kHz) { +TEST(LevelControlBitExactnessTest, Mono8kHz) { const float kOutputReference[] = {-0.013939f, -0.012154f, -0.009054f}; RunBitexactnessTest(AudioProcessing::kSampleRate8kHz, 1, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_Mono16kHz) { +TEST(LevelControlBitExactnessTest, Mono16kHz) { const float kOutputReference[] = {-0.013706f, -0.013215f, -0.013018f}; RunBitexactnessTest(AudioProcessing::kSampleRate16kHz, 1, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_Mono32kHz) { +TEST(LevelControlBitExactnessTest, Mono32kHz) { const float kOutputReference[] = {-0.014495f, -0.016425f, -0.016085f}; RunBitexactnessTest(AudioProcessing::kSampleRate32kHz, 1, rtc::Optional(), kOutputReference); @@ -108,47 +108,47 @@ TEST(LevelControlBitExactnessTest, DISABLED_Mono32kHz) { // TODO(peah): Investigate why this particular testcase differ between Android // and the rest of the platforms. -TEST(LevelControlBitExactnessTest, DISABLED_Mono48kHz) { +TEST(LevelControlBitExactnessTest, Mono48kHz) { #if !(defined(WEBRTC_ARCH_ARM64) || defined(WEBRTC_ARCH_ARM) || \ defined(WEBRTC_ANDROID)) const float kOutputReference[] = {-0.014277f, -0.015180f, -0.017437f}; #else - const float kOutputReference[] = {-0.015949f, -0.016957f, -0.019478f}; + const float kOutputReference[] = {-0.014306f, -0.015209f, -0.017466f}; #endif RunBitexactnessTest(AudioProcessing::kSampleRate48kHz, 1, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_Stereo8kHz) { +TEST(LevelControlBitExactnessTest, Stereo8kHz) { const float kOutputReference[] = {-0.014063f, -0.008450f, -0.012159f, -0.051967f, -0.023202f, -0.047858f}; RunBitexactnessTest(AudioProcessing::kSampleRate8kHz, 2, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_Stereo16kHz) { +TEST(LevelControlBitExactnessTest, Stereo16kHz) { const float kOutputReference[] = {-0.012714f, -0.005896f, -0.012220f, -0.053306f, -0.024549f, -0.051527f}; RunBitexactnessTest(AudioProcessing::kSampleRate16kHz, 2, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_Stereo32kHz) { - const float kOutputReference[] = {-0.011737f, -0.007018f, -0.013446f, - -0.053505f, -0.026292f, -0.056221f}; +TEST(LevelControlBitExactnessTest, Stereo32kHz) { + const float kOutputReference[] = {-0.011764f, -0.007044f, -0.013472f, + -0.053537f, -0.026322f, -0.056253f}; RunBitexactnessTest(AudioProcessing::kSampleRate32kHz, 2, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_Stereo48kHz) { +TEST(LevelControlBitExactnessTest, Stereo48kHz) { const float kOutputReference[] = {-0.010643f, -0.006334f, -0.011377f, -0.049088f, -0.023600f, -0.050465f}; RunBitexactnessTest(AudioProcessing::kSampleRate48kHz, 2, rtc::Optional(), kOutputReference); } -TEST(LevelControlBitExactnessTest, DISABLED_MonoInitial48kHz) { - const float kOutputReference[] = {-0.013753f, -0.014623f, -0.016797f}; +TEST(LevelControlBitExactnessTest, MonoInitial48kHz) { + const float kOutputReference[] = {-0.013884f, -0.014761f, -0.016951f}; RunBitexactnessTest(AudioProcessing::kSampleRate48kHz, 1, rtc::Optional(-50), kOutputReference); }