From 4d9e428286856a18a75aff2012ceaed3bd4cc485 Mon Sep 17 00:00:00 2001 From: Elad Alon Date: Mon, 3 Jun 2019 22:28:10 +0200 Subject: [PATCH] Remove some leftover TODOs for webrtc:10336 Some of the TODOs associated with webrtc:10336 which are currently in the codebase have recently been resolved, but not all relevant TODOs have been removed. TBR=kwiberg@webrtc.org Bug: webrtc:10336 Change-Id: Iff1d0fc94dee5bf49226f6ea3d9127fea77e9d68 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139902 Reviewed-by: Elad Alon Commit-Queue: Elad Alon Cr-Commit-Position: refs/heads/master@{#28167} --- modules/include/module_common_types.h | 1 - video/rtp_video_stream_receiver.cc | 3 --- 2 files changed, 4 deletions(-) diff --git a/modules/include/module_common_types.h b/modules/include/module_common_types.h index ab103567c4..83b63a6e74 100644 --- a/modules/include/module_common_types.h +++ b/modules/include/module_common_types.h @@ -93,7 +93,6 @@ class KeyFrameRequestSender { }; // Interface used by LossNotificationController to communicate to RtpRtcp. -// TODO(bugs.webrtc.org/10336): Hook up to RtpRtcp. class LossNotificationSender { public: virtual ~LossNotificationSender() {} diff --git a/video/rtp_video_stream_receiver.cc b/video/rtp_video_stream_receiver.cc index 668dfa45f6..aae1f097ac 100644 --- a/video/rtp_video_stream_receiver.cc +++ b/video/rtp_video_stream_receiver.cc @@ -336,9 +336,6 @@ int32_t RtpVideoStreamReceiver::OnReceivedPayloadData( RTC_LOG(LS_WARNING) << "LossNotificationController does not support reordering."; } else { - // TODO(bugs.webrtc.org/10336): Coordinate with |nack_module_| to make - // sure that only a single RTCP packet is produced if both a LNTF as - // well as a NACK (or key frame request) should be issued. loss_notification_controller_->OnReceivedPacket(packet); } }