From 4cd92d88ea1015d20052fb245f103746f52971ee Mon Sep 17 00:00:00 2001 From: Jakob Ivarsson Date: Sat, 31 Oct 2020 12:40:43 +0100 Subject: [PATCH] Use non-null transport for RTCP in AV sync test. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes a bug where TWCC feedback messages were not forwarded to the sender which results in BWE dropping down to the minimum bitrate. This is blocking landing of: https://webrtc-review.googlesource.com/c/src/+/188801 since it causes excessive pacing at low bitrates. Bug: webrtc:6762 Change-Id: I34947967a60c2a09937df33e9d6f17b51a644152 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191220 Reviewed-by: Erik Språng Commit-Queue: Jakob Ivarsson Cr-Commit-Position: refs/heads/master@{#32532} --- call/call_perf_tests.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/call/call_perf_tests.cc b/call/call_perf_tests.cc index ac1d29eed5..7ddf547a2d 100644 --- a/call/call_perf_tests.cc +++ b/call/call_perf_tests.cc @@ -182,7 +182,6 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec, std::unique_ptr audio_send_transport; std::unique_ptr video_send_transport; std::unique_ptr receive_transport; - test::NullTransport rtcp_send_transport; AudioSendStream* audio_send_stream; AudioReceiveStream* audio_receive_stream; @@ -271,7 +270,7 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec, AudioReceiveStream::Config audio_recv_config; audio_recv_config.rtp.remote_ssrc = kAudioSendSsrc; audio_recv_config.rtp.local_ssrc = kAudioRecvSsrc; - audio_recv_config.rtcp_send_transport = &rtcp_send_transport; + audio_recv_config.rtcp_send_transport = receive_transport.get(); audio_recv_config.sync_group = kSyncGroup; audio_recv_config.decoder_factory = audio_decoder_factory_; audio_recv_config.decoder_map = {