Remove/update TODOs assigned to alessiob
Bug: webrtc:379542219 Change-Id: I1da54a9a13187d9e7d836dd4e1a85e49b685d971 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368540 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43420}
This commit is contained in:
parent
56085ea0d1
commit
4c9dbd508d
@ -14,7 +14,7 @@
|
||||
#ifndef COMMON_AUDIO_RING_BUFFER_H_
|
||||
#define COMMON_AUDIO_RING_BUFFER_H_
|
||||
|
||||
// TODO(alessiob): Used by AEC, AECm and AudioRingBuffer. Remove when possible.
|
||||
// TODO(https://issues.webrtc.org/379542219): Remove when AECm gets removed.
|
||||
|
||||
#ifdef __cplusplus
|
||||
extern "C" {
|
||||
|
||||
@ -162,7 +162,6 @@ class LappedTransform {
|
||||
Callback* const block_processor_;
|
||||
Blocker blocker_;
|
||||
|
||||
// TODO(alessiob): Replace RealFourier with a different FFT library.
|
||||
std::unique_ptr<RealFourier> fft_;
|
||||
const size_t cplx_length_;
|
||||
AlignedArray<float> real_buf_;
|
||||
|
||||
@ -54,7 +54,6 @@ rtc_library("rnn_vad_auto_correlation") {
|
||||
}
|
||||
|
||||
rtc_source_set("rnn_vad_common") {
|
||||
# TODO(alessiob): Make this target visibility private.
|
||||
visibility = [
|
||||
":*",
|
||||
"..:vad_wrapper",
|
||||
|
||||
@ -169,9 +169,6 @@ void FakeRecordingDevice::SetMicLevel(const int level) {
|
||||
|
||||
void FakeRecordingDevice::SetUndoMicLevel(const int level) {
|
||||
RTC_DCHECK(worker_);
|
||||
// TODO(alessiob): The behavior with undo level equal to zero is not clear yet
|
||||
// and will be defined in future CLs once more FakeRecordingDeviceWorker
|
||||
// implementations need to be added.
|
||||
RTC_CHECK(level > 0) << "Zero undo mic level is unsupported";
|
||||
worker_->set_undo_mic_level(level);
|
||||
}
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user