admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove using declaration for rtc::Buffer

Browse Source 
It interferes with a future refactoring, and isn't all that useful
anyway.

Bug: webrtc:9810
Change-Id: I46163d7921d39249615b7eea60306c598f13c128
Reviewed-on: https://webrtc-review.googlesource.com/c/103443
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24970}
This commit is contained in:
Karl Wiberg 2018-10-03 15:17:14 +02:00 committed by Commit Bot
parent 9e24dcff16
commit 4b6c2ec5db
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
p2p/base/port_unittest.cc
View File

@ -36,7 +36,6 @@
#include "rtc_base/virtualsocketserver.h"
using rtc::AsyncPacketSocket;
using rtc::Buffer;
using rtc::ByteBufferReader;
using rtc::ByteBufferWriter;
using rtc::NATType;
@ -134,7 +133,7 @@ class TestPort : public Port {
// The last StunMessage that was sent on this Port.
// TODO(?): Make these const; requires changes to SendXXXXResponse.
Buffer* last_stun_buf() { return last_stun_buf_.get(); }
rtc::BufferT<uint8_t>* last_stun_buf() { return last_stun_buf_.get(); }
IceMessage* last_stun_msg() { return last_stun_msg_.get(); }
int last_stun_error_code() {
int code = 0;
@ -191,7 +190,8 @@ class TestPort : public Port {
bool payload) {
if (!payload) {
IceMessage* msg = new IceMessage;
Buffer* buf = new Buffer(static_cast<const char*>(data), size);
auto* buf =
new rtc::BufferT<uint8_t>(static_cast<const char*>(data), size);
ByteBufferReader read_buf(*buf);
if (!msg->Read(&read_buf)) {
delete msg;
@ -219,7 +219,7 @@ class TestPort : public Port {
const rtc::SentPacket& sent_packet) {
PortInterface::SignalSentPacket(sent_packet);
}
std::unique_ptr<Buffer> last_stun_buf_;
std::unique_ptr<rtc::BufferT<uint8_t>> last_stun_buf_;
std::unique_ptr<IceMessage> last_stun_msg_;
int type_preference_ = 0;
};