admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make purple bots happy: Shorten TEST_P names.

Browse Source 
The recently added tests resulted in some .log file on some bots being
too long:

video_engine_tests_exe-VideoStreamEncoderStandardOrLegacyRequestedResolutionTest_VideoStreamEncoderStandardOrLegacyRequestedResolutionTest_RequestedResolutionInWrongAspectRatioAndSourceIsAdapting_0-1.log

This CL makes the test names significantly shorter.

# Trivial and believed to fix purple bots, let's land ASAP
NOTRY=True

Bug: webrtc:367066321
Change-Id: I831911947af9d5639d1edb559470f1c9ae702d6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362721
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43030}
This commit is contained in:
Henrik Boström 2024-09-17 13:01:02 +02:00 committed by WebRTC LUCI CQ
parent 59d592ebac
commit 4b51217ef6
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
video/video_stream_encoder_unittest.cc
View File

@ -2537,11 +2537,11 @@ enum class RequestedResolutionVersion {
kLegacyRequestedResolution, kLegacyRequestedResolution,
kStandardRequestedResolution, kStandardRequestedResolution,
}; };
class VideoStreamEncoderStandardOrLegacyRequestedResolutionTest class VideoStreamEncoderResolutionTest
: public VideoStreamEncoderTest, : public VideoStreamEncoderTest,
public ::testing::WithParamInterface<RequestedResolutionVersion> { public ::testing::WithParamInterface<RequestedResolutionVersion> {
public: public:
VideoStreamEncoderStandardOrLegacyRequestedResolutionTest() VideoStreamEncoderResolutionTest()
: VideoStreamEncoderTest(), requested_resolution_version_(GetParam()) {} : VideoStreamEncoderTest(), requested_resolution_version_(GetParam()) {}
void SetUp() override { void SetUp() override {
@ -2573,14 +2573,13 @@ class VideoStreamEncoderStandardOrLegacyRequestedResolutionTest
}; };
INSTANTIATE_TEST_SUITE_P( INSTANTIATE_TEST_SUITE_P(
VideoStreamEncoderStandardOrLegacyRequestedResolutionTest, VideoStreamEncoderResolutionTest,
VideoStreamEncoderStandardOrLegacyRequestedResolutionTest, VideoStreamEncoderResolutionTest,
::testing::Values( ::testing::Values(
RequestedResolutionVersion::kLegacyRequestedResolution, RequestedResolutionVersion::kLegacyRequestedResolution,
RequestedResolutionVersion::kStandardRequestedResolution)); RequestedResolutionVersion::kStandardRequestedResolution));
TEST_P(VideoStreamEncoderStandardOrLegacyRequestedResolutionTest, TEST_P(VideoStreamEncoderResolutionTest, RequestInSinkWantsBeforeFirstFrame) {
ResolutionLimitMaybePropagatedToSinkWantsBeforeFirstFrame) {
ASSERT_THAT(video_encoder_config_.simulcast_layers, SizeIs(1)); ASSERT_THAT(video_encoder_config_.simulcast_layers, SizeIs(1));
video_encoder_config_.simulcast_layers[0].requested_resolution.emplace( video_encoder_config_.simulcast_layers[0].requested_resolution.emplace(
Resolution({.width = 320, .height = 160})); Resolution({.width = 320, .height = 160}));
@ -2618,8 +2617,7 @@ TEST_P(VideoStreamEncoderStandardOrLegacyRequestedResolutionTest,
video_stream_encoder_->Stop(); video_stream_encoder_->Stop();
} }
TEST_P(VideoStreamEncoderStandardOrLegacyRequestedResolutionTest, TEST_P(VideoStreamEncoderResolutionTest, RequestInWrongAspectRatioWithAdapter) {
RequestedResolutionInWrongAspectRatioAndSourceIsAdapting) {
// Use a source that adapts resolution based on OnSinkWants. // Use a source that adapts resolution based on OnSinkWants.
AdaptingFrameForwarder source(&time_controller_); AdaptingFrameForwarder source(&time_controller_);
source.set_adaptation_enabled(true); source.set_adaptation_enabled(true);