diff --git a/webrtc/modules/audio_device/android/audio_device_unittest.cc b/webrtc/modules/audio_device/android/audio_device_unittest.cc index 7655c820ad..48944f5772 100644 --- a/webrtc/modules/audio_device/android/audio_device_unittest.cc +++ b/webrtc/modules/audio_device/android/audio_device_unittest.cc @@ -562,7 +562,7 @@ class AudioDeviceTest : public ::testing::Test { rtc::scoped_refptr CreateAudioDevice( AudioDeviceModule::AudioLayer audio_layer) { rtc::scoped_refptr module( - AudioDeviceModuleImpl::Create(0, audio_layer)); + AudioDeviceModule::Create(0, audio_layer)); return module; } diff --git a/webrtc/modules/audio_device/android/audio_record_jni.h b/webrtc/modules/audio_device/android/audio_record_jni.h index 13194939b6..de58468c9a 100644 --- a/webrtc/modules/audio_device/android/audio_record_jni.h +++ b/webrtc/modules/audio_device/android/audio_record_jni.h @@ -156,7 +156,7 @@ class AudioRecordJni { bool recording_; // Raw pointer handle provided to us in AttachAudioBuffer(). Owned by the - // AudioDeviceModuleImpl class and called by AudioDeviceModuleImpl::Create(). + // AudioDeviceModuleImpl class and called by AudioDeviceModule::Create(). AudioDeviceBuffer* audio_device_buffer_; }; diff --git a/webrtc/modules/audio_device/android/audio_track_jni.h b/webrtc/modules/audio_device/android/audio_track_jni.h index 82f2113f0a..2c78a5901c 100644 --- a/webrtc/modules/audio_device/android/audio_track_jni.h +++ b/webrtc/modules/audio_device/android/audio_track_jni.h @@ -144,7 +144,7 @@ class AudioTrackJni { bool playing_; // Raw pointer handle provided to us in AttachAudioBuffer(). Owned by the - // AudioDeviceModuleImpl class and called by AudioDeviceModuleImpl::Create(). + // AudioDeviceModuleImpl class and called by AudioDeviceModule::Create(). // The AudioDeviceBuffer is a member of the AudioDeviceModuleImpl instance // and therefore outlives this object. AudioDeviceBuffer* audio_device_buffer_; diff --git a/webrtc/modules/audio_device/android/opensles_player.h b/webrtc/modules/audio_device/android/opensles_player.h index 084546dbf7..4058ff9994 100644 --- a/webrtc/modules/audio_device/android/opensles_player.h +++ b/webrtc/modules/audio_device/android/opensles_player.h @@ -132,7 +132,7 @@ class OpenSLESPlayer { const AudioParameters audio_parameters_; // Raw pointer handle provided to us in AttachAudioBuffer(). Owned by the - // AudioDeviceModuleImpl class and called by AudioDeviceModuleImpl::Create(). + // AudioDeviceModuleImpl class and called by AudioDeviceModule::Create(). AudioDeviceBuffer* audio_device_buffer_; bool initialized_; diff --git a/webrtc/modules/audio_device/audio_device_impl.cc b/webrtc/modules/audio_device/audio_device_impl.cc index 6576f5d8e9..23ac1e4650 100644 --- a/webrtc/modules/audio_device/audio_device_impl.cc +++ b/webrtc/modules/audio_device/audio_device_impl.cc @@ -76,12 +76,12 @@ namespace webrtc { // AudioDeviceModule::Create() // ---------------------------------------------------------------------------- -rtc::scoped_refptr AudioDeviceModuleImpl::Create( +rtc::scoped_refptr AudioDeviceModule::Create( const int32_t id, - const AudioLayer audioLayer) { + const AudioLayer audio_layer) { // Create the generic ref counted (platform independent) implementation. rtc::scoped_refptr audioDevice( - new rtc::RefCountedObject(id, audioLayer)); + new rtc::RefCountedObject(id, audio_layer)); // Ensure that the current platform is supported. if (audioDevice->CheckPlatform() == -1) diff --git a/webrtc/modules/audio_device/audio_device_impl.h b/webrtc/modules/audio_device/audio_device_impl.h index a112e3e3bf..044ec4ed6b 100644 --- a/webrtc/modules/audio_device/audio_device_impl.h +++ b/webrtc/modules/audio_device/audio_device_impl.h @@ -16,7 +16,6 @@ #include #include "webrtc/base/checks.h" -#include "webrtc/base/scoped_ref_ptr.h" #include "webrtc/modules/audio_device/audio_device_buffer.h" #include "webrtc/modules/audio_device/include/audio_device.h" @@ -48,11 +47,6 @@ class AudioDeviceModuleImpl : public AudioDeviceModule { int64_t TimeUntilNextProcess() override; void Process() override; - // Factory methods (resource allocation/deallocation) - static rtc::scoped_refptr Create( - const int32_t id, - const AudioLayer audioLayer = kPlatformDefaultAudio); - // Retrieve the currently utilized audio layer int32_t ActiveAudioLayer(AudioLayer* audioLayer) const override; diff --git a/webrtc/modules/audio_device/include/audio_device.h b/webrtc/modules/audio_device/include/audio_device.h index d8df05cec8..8457a6b771 100644 --- a/webrtc/modules/audio_device/include/audio_device.h +++ b/webrtc/modules/audio_device/include/audio_device.h @@ -11,6 +11,7 @@ #ifndef MODULES_AUDIO_DEVICE_INCLUDE_AUDIO_DEVICE_H_ #define MODULES_AUDIO_DEVICE_INCLUDE_AUDIO_DEVICE_H_ +#include "webrtc/base/scoped_ref_ptr.h" #include "webrtc/modules/audio_device/include/audio_device_defines.h" #include "webrtc/modules/include/module.h" @@ -51,6 +52,11 @@ class AudioDeviceModule : public RefCountedModule { }; public: + // Create an ADM. + static rtc::scoped_refptr Create( + const int32_t id, + const AudioLayer audio_layer); + // Retrieve the currently utilized audio layer virtual int32_t ActiveAudioLayer(AudioLayer* audioLayer) const = 0; diff --git a/webrtc/modules/audio_device/ios/audio_device_ios.h b/webrtc/modules/audio_device/ios/audio_device_ios.h index 786f718a22..8e630dd1a8 100644 --- a/webrtc/modules/audio_device/ios/audio_device_ios.h +++ b/webrtc/modules/audio_device/ios/audio_device_ios.h @@ -217,7 +217,7 @@ class AudioDeviceIOS : public AudioDeviceGeneric, std::unique_ptr async_invoker_; // Raw pointer handle provided to us in AttachAudioBuffer(). Owned by the - // AudioDeviceModuleImpl class and called by AudioDeviceModuleImpl::Create(). + // AudioDeviceModuleImpl class and called by AudioDeviceModule::Create(). // The AudioDeviceBuffer is a member of the AudioDeviceModuleImpl instance // and therefore outlives this object. AudioDeviceBuffer* audio_device_buffer_; diff --git a/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc b/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc index 4dfb073fa9..ec10119a11 100644 --- a/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc +++ b/webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc @@ -537,7 +537,7 @@ class AudioDeviceTest : public ::testing::Test { rtc::scoped_refptr CreateAudioDevice( AudioDeviceModule::AudioLayer audio_layer) { rtc::scoped_refptr module( - AudioDeviceModuleImpl::Create(0, audio_layer)); + AudioDeviceModule::Create(0, audio_layer)); return module; } diff --git a/webrtc/modules/audio_device/test/audio_device_test_api.cc b/webrtc/modules/audio_device/test/audio_device_test_api.cc index 78642c3292..dad42a0c0b 100644 --- a/webrtc/modules/audio_device/test/audio_device_test_api.cc +++ b/webrtc/modules/audio_device/test/audio_device_test_api.cc @@ -153,75 +153,75 @@ class AudioDeviceAPITest: public testing::Test { const int32_t kId = 444; #if defined(_WIN32) - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kLinuxAlsaAudio)) == NULL); #if defined(WEBRTC_WINDOWS_CORE_AUDIO_BUILD) TEST_LOG("WEBRTC_WINDOWS_CORE_AUDIO_BUILD is defined!\n\n"); // create default implementation (=Core Audio) instance - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kPlatformDefaultAudio)) != NULL); EXPECT_EQ(0, audio_device_.release()->Release()); // create non-default (=Wave Audio) instance - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsWaveAudio)) != NULL); EXPECT_EQ(0, audio_device_.release()->Release()); // explicitly specify usage of Core Audio (same as default) - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsCoreAudio)) != NULL); #else TEST_LOG("WEBRTC_WINDOWS_CORE_AUDIO_BUILD is *not* defined!\n"); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsCoreAudio)) == NULL); // create default implementation (=Wave Audio) instance - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kPlatformDefaultAudio)) != NULL); EXPECT_EQ(0, audio_device_.release()->Release()); // explicitly specify usage of Wave Audio (same as default) - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsWaveAudio)) != NULL); #endif #endif #if defined(ANDROID) // Fails tests - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsWaveAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsCoreAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kLinuxAlsaAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kLinuxPulseAudio)) == NULL); // Create default implementation instance - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kPlatformDefaultAudio)) != NULL); #elif defined(WEBRTC_LINUX) - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsWaveAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsCoreAudio)) == NULL); // create default implementation instance - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kPlatformDefaultAudio)) != NULL); EXPECT_EQ(0, audio_device_->Terminate()); EXPECT_EQ(0, audio_device_.release()->Release()); // explicitly specify usage of Pulse Audio (same as default) - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kLinuxPulseAudio)) != NULL); #endif #if defined(WEBRTC_MAC) // Fails tests - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsWaveAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kWindowsCoreAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kLinuxAlsaAudio)) == NULL); - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kLinuxPulseAudio)) == NULL); // Create default implementation instance - EXPECT_TRUE((audio_device_ = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((audio_device_ = AudioDeviceModule::Create( kId, AudioDeviceModule::kPlatformDefaultAudio)) != NULL); #endif diff --git a/webrtc/modules/audio_device/test/func_test_manager.cc b/webrtc/modules/audio_device/test/func_test_manager.cc index cc589653f7..f16f296011 100644 --- a/webrtc/modules/audio_device/test/func_test_manager.cc +++ b/webrtc/modules/audio_device/test/func_test_manager.cc @@ -602,7 +602,7 @@ int32_t FuncTestManager::Init() _processThread->Start(); // create the Audio Device module - EXPECT_TRUE((_audioDevice = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((_audioDevice = AudioDeviceModule::Create( 555, ADM_AUDIO_LAYER)) != NULL); if (_audioDevice == NULL) { @@ -842,12 +842,12 @@ int32_t FuncTestManager::TestAudioLayerSelection() // create the Audio Device module based on selected audio layer if (tryWinWave) { - _audioDevice = AudioDeviceModuleImpl::Create( + _audioDevice = AudioDeviceModule::Create( 555, AudioDeviceModule::kWindowsWaveAudio); } else if (tryWinCore) { - _audioDevice = AudioDeviceModuleImpl::Create( + _audioDevice = AudioDeviceModule::Create( 555, AudioDeviceModule::kWindowsCoreAudio); } @@ -856,7 +856,7 @@ int32_t FuncTestManager::TestAudioLayerSelection() { TEST_LOG("\nERROR: Switch of audio layer failed!\n"); // restore default audio layer instead - EXPECT_TRUE((_audioDevice = AudioDeviceModuleImpl::Create( + EXPECT_TRUE((_audioDevice = AudioDeviceModule::Create( 555, AudioDeviceModule::kPlatformDefaultAudio)) != NULL); } diff --git a/webrtc/voice_engine/voe_base_impl.cc b/webrtc/voice_engine/voe_base_impl.cc index c9d5e178e9..8e93778f7e 100644 --- a/webrtc/voice_engine/voe_base_impl.cc +++ b/webrtc/voice_engine/voe_base_impl.cc @@ -229,7 +229,7 @@ int VoEBaseImpl::Init(AudioDeviceModule* external_adm, return -1; #else // Create the internal ADM implementation. - shared_->set_audio_device(AudioDeviceModuleImpl::Create( + shared_->set_audio_device(AudioDeviceModule::Create( VoEId(shared_->instance_id(), -1), shared_->audio_device_layer())); if (shared_->audio_device() == nullptr) {