admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Stats] Include fecPackets[Reeceived/Discarded] in Members()

Browse Source 
This refers to modern getStats() only. The metrics has been implemented
for a while in C++ but was accidentally not included in the Members()
list, meaning they were not exposed in lists (including exposure in
Chrome/JavaScript).

The Chromium whitelist already include them.

TBR=hta@webrtc.org

Bug: webrtc:11317
Change-Id: I0c3ee9c552975fc37db2d87196c66e662c994aed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167530
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30391}
This commit is contained in:
Henrik Boström 2020-01-28 11:15:35 +01:00 committed by Commit Bot
parent 086055d0fd
commit 4a5dab00ae
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pc/rtc_stats_integrationtest.cc
View File

@ -795,6 +795,9 @@ class RTCStatsReportVerifier {
inbound_stream.fec_packets_received); inbound_stream.fec_packets_received);
verifier.TestMemberIsNonNegative<uint64_t>( verifier.TestMemberIsNonNegative<uint64_t>(
inbound_stream.fec_packets_discarded); inbound_stream.fec_packets_discarded);
} else {
verifier.TestMemberIsUndefined(inbound_stream.fec_packets_received);
verifier.TestMemberIsUndefined(inbound_stream.fec_packets_discarded);
} }
verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received); verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received);
verifier.TestMemberIsNonNegative<uint64_t>( verifier.TestMemberIsNonNegative<uint64_t>(

2
stats/rtcstats_objects.cc
View File

@ -594,6 +594,8 @@ RTCRTPStreamStats::~RTCRTPStreamStats() {}
WEBRTC_RTCSTATS_IMPL( WEBRTC_RTCSTATS_IMPL(
RTCInboundRTPStreamStats, RTCRTPStreamStats, "inbound-rtp", RTCInboundRTPStreamStats, RTCRTPStreamStats, "inbound-rtp",
&packets_received, &packets_received,
&fec_packets_received,
&fec_packets_discarded,
&bytes_received, &bytes_received,
&header_bytes_received, &header_bytes_received,
&packets_lost, &packets_lost,