From 4a3c9f60a39b82ef27bd4582c088fa5af5a24566 Mon Sep 17 00:00:00 2001
From: eladalon <eladalon@webrtc.org>
Date: Fri, 2 Jun 2017 03:37:48 -0700
Subject: [PATCH] Prevent memory corruption by StreamId::Set

Use RTC_CHECK to crash if attempting to set an RSID whose name's length exceeds the maximum.

BUG=None

Review-Url: https://codereview.webrtc.org/2915913003
Cr-Commit-Position: refs/heads/master@{#18405}
---
 webrtc/common_types.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webrtc/common_types.cc b/webrtc/common_types.cc
index b9c4737aeb..c9f7fa1e73 100644
--- a/webrtc/common_types.cc
+++ b/webrtc/common_types.cc
@@ -25,7 +25,7 @@ constexpr size_t StreamId::kMaxSize;
 
 void StreamId::Set(const char* data, size_t size) {
   // If |data| contains \0, the stream id size might become less than |size|.
-  RTC_DCHECK_LE(size, kMaxSize);
+  RTC_CHECK_LE(size, kMaxSize);
   memcpy(value_, data, size);
   if (size < kMaxSize)
     value_[size] = 0;