admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated PlotPython and PlotProtobuf subclasses.

Browse Source 
(Use Plot directly instead when visualizing RTC event logs.)

Bug: None
Change-Id: I374e00cdccd990dfd5c707eebcf7c792c2cc7625
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329160
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#41284}
This commit is contained in:
Bjorn Terelius 2023-11-29 14:51:55 +01:00 committed by WebRTC LUCI CQ
parent 3bdb49b483
commit 4a2ea71a0f
5 changed files with 0 additions and 171 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rtc_tools/BUILD.gn
View File

@ -371,10 +371,6 @@ if (!build_with_chromium) {
"rtc_event_log_visualizer/log_simulation.h",
"rtc_event_log_visualizer/plot_base.cc",
"rtc_event_log_visualizer/plot_base.h",
"rtc_event_log_visualizer/plot_protobuf.cc",
"rtc_event_log_visualizer/plot_protobuf.h",
"rtc_event_log_visualizer/plot_python.cc",
"rtc_event_log_visualizer/plot_python.h",
]
deps = [
":chart_proto",

43
rtc_tools/rtc_event_log_visualizer/plot_protobuf.cc
View File

@ -1,43 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "rtc_tools/rtc_event_log_visualizer/plot_protobuf.h"
#include <stddef.h>
#include <iostream>
#include <memory>
#include <vector>
namespace webrtc {
ProtobufPlot::ProtobufPlot() {}
ProtobufPlot::~ProtobufPlot() {}
void ProtobufPlot::Draw() {}
ProtobufPlotCollection::ProtobufPlotCollection() {}
ProtobufPlotCollection::~ProtobufPlotCollection() {}
void ProtobufPlotCollection::Draw() {
webrtc::analytics::ChartCollection collection;
ExportProtobuf(&collection);
std::cout << collection.SerializeAsString();
}
Plot* ProtobufPlotCollection::AppendNewPlot() {
Plot* plot = new ProtobufPlot();
plots_.push_back(std::unique_ptr<Plot>(plot));
return plot;
}
} // namespace webrtc

39
rtc_tools/rtc_event_log_visualizer/plot_protobuf.h
View File

@ -1,39 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_
#define RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_
#include "absl/base/attributes.h"
#include "rtc_tools/rtc_event_log_visualizer/plot_base.h"
// Generated at build-time by the protobuf compiler.
#include "rtc_tools/rtc_event_log_visualizer/proto/chart.pb.h"
namespace webrtc {
class ProtobufPlot final : public Plot {
public:
ProtobufPlot();
~ProtobufPlot() override;
void Draw() override;
};
class ABSL_DEPRECATED("Use PlotCollection and ExportProtobuf() instead")
ProtobufPlotCollection final : public PlotCollection {
public:
ProtobufPlotCollection();
~ProtobufPlotCollection() override;
void Draw() override;
Plot* AppendNewPlot() override;
};
} // namespace webrtc
#endif // RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_

46
rtc_tools/rtc_event_log_visualizer/plot_python.cc
View File

@ -1,46 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "rtc_tools/rtc_event_log_visualizer/plot_python.h"
#include <stdio.h>
#include <memory>
#include <string>
#include <vector>
#include "rtc_base/checks.h"
namespace webrtc {
PythonPlot::PythonPlot() {}
PythonPlot::~PythonPlot() {}
void PythonPlot::Draw() {
PrintPythonCode();
}
PythonPlotCollection::PythonPlotCollection(bool shared_xaxis)
: shared_xaxis_(shared_xaxis) {}
PythonPlotCollection::~PythonPlotCollection() {}
void PythonPlotCollection::Draw() {
PrintPythonCode(shared_xaxis_);
}
Plot* PythonPlotCollection::AppendNewPlot() {
Plot* plot = new PythonPlot();
plots_.push_back(std::unique_ptr<Plot>(plot));
return plot;
}
} // namespace webrtc

39
rtc_tools/rtc_event_log_visualizer/plot_python.h
View File

@ -1,39 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_
#define RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_
#include "absl/base/attributes.h"
#include "rtc_tools/rtc_event_log_visualizer/plot_base.h"
namespace webrtc {
class PythonPlot final : public Plot {
public:
PythonPlot();
~PythonPlot() override;
void Draw() override;
};
class ABSL_DEPRECATED("Use PlotCollection and PrintPythonCode() instead.")
PythonPlotCollection final : public PlotCollection {
public:
explicit PythonPlotCollection(bool shared_xaxis = false);
~PythonPlotCollection() override;
void Draw() override;
Plot* AppendNewPlot() override;
private:
bool shared_xaxis_;
};
} // namespace webrtc
#endif // RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_